Skip to contentSkip to conversation

remove outdated/misleading CPU scheduler comments

PATCH In review Josh Aas 2 participants 2 messages Dec 31, 2004 – Jan 4, 2005

lore
Share & tools
lore

Josh Aas

author
#0 lore raw

PATCH 1/1 remove outdated/misleading CPU scheduler comments

This patch removes two outdated/misleading comments from the CPU scheduler.

1) The first comment removed is simply incorrect. The function it comments on is not used for what the comments says it is anymore.
2) The second comment is a leftover from when the "if" block it comments on contained a goto. It does not any more, and the comment doesn't make sense.

There isn't really a reason to add different comments, though someone might feel differently in the case of the second one. I'll leave adding a comment to anybody who wants to - more important to just get rid of them now.

Signed-off-by Josh Aas <[email protected]>
Signature · 3 lines
Josh Aas
Linux System Software
Silicon Graphics, Inc. (SGI)
kernel/sched.c +1 -9
@@ -580,11 +580,6 @@ static void enqueue_task(struct task_str
 	p->array = array;
 }
 
-/*
- * Used by the migration code - we pull tasks from the head of the
- * remote queue so we want these tasks to show up at the head of the
- * local queue:
- */
 static inline void enqueue_task_head(struct task_struct *p, prio_array_t *array)
 {
 	list_add(&p->run_list, array->queue + p->prio);

@@ -2585,10 +2580,7 @@ need_resched_nonpreemptible:
 
 	if (unlikely(current->flags & PF_DEAD))
 		current->state = EXIT_DEAD;
-	/*
-	 * if entering off of a kernel preemption go straight
-	 * to picking the next task.
-	 */
+
 	switch_count = &prev->nivcsw;
 	if (prev->state && !(preempt_count() & PREEMPT_ACTIVE)) {
 		switch_count = &prev->nvcsw;