Skip to contentSkip to conversation

PPC64: 32bit wrapper for ioctls.

PATCH In review Mike Wolf 2 participants 2 messages Jan 13, 2005 – Jan 14, 2005

lore
Share & tools
lore

Mike Wolf

author
#0 lore raw

PATCH 1/1 PPC64: 32bit wrapper for ioctls.

Hi Paul,
The patch adds some 32bit wrappers for 2 ioctls that Java needs.
Assuming this doesn't generate a round of discussion, please forward upstream to akpm/torvalds.

arch/ppc64/kernel/ioctl32.c +2 -0
@@ -43,6 +43,8 @@
 COMPATIBLE_IOCTL(TIOCSTART)
 COMPATIBLE_IOCTL(TIOCSTOP)
 COMPATIBLE_IOCTL(TIOCSLTC)
+COMPATIBLE_IOCTL(TIOCMIWAIT)
+COMPATIBLE_IOCTL(TIOCGICOUNT)
 /* Little p (/dev/rtc, /dev/envctrl, etc.) */
 COMPATIBLE_IOCTL(_IOR('p', 20, int[7])) /* RTCGET */
 COMPATIBLE_IOCTL(_IOW('p', 21, int[7])) /* RTCSET */
#1 lore raw
Quoted 4 lines · Mike Wolf

Hi Paul,
  The patch adds some 32bit wrappers for 2 ioctls that Java needs. Assuming this doesn't generate a round of discussion, please forward upstream to akpm/torvalds.

Why add them to arch/ppc64? These don't look architecture specific, so they should go into include/linux/compat_ioctl.h.

arch/ppc64/kernel/ioctl32.c      2005-01-13 10:51:43.450433277 -0600 line 46

Quoted 7 lines
arch/ppc64/kernel/ioctl32.c      2005-01-13 10:51:43.450433277 -0600 renamed from arch/ppc64/kernel/ioctl32.c 2005-01-13 10:35:10.165539000 -0600 +1 -0
@@ -43,6 +43,8 @@
  COMPATIBLE_IOCTL(TIOCSTART)
  COMPATIBLE_IOCTL(TIOCSTOP)
  COMPATIBLE_IOCTL(TIOCSLTC)
+COMPATIBLE_IOCTL(TIOCMIWAIT)

Note that TIOCMIWAIT is not COMPATIBLE_IOCTL, but ULONG_IOCTL. It doesn't make a difference for ppc64, but if you add it to the generic file that is needed for s390x.

	Arnd <><