Skip to contentSkip to conversation

relayfs for 2.6.10: headers

PATCH In review Karim Yaghmour 3 participants 6 messages Jan 14, 2005 – Jan 15, 2005 Generic include/asm header files

lore
Share & tools
lore

Karim Yaghmour

author
#0 lore raw

PATCH 4/4 relayfs for 2.6.10: headers

Signed-off-by Karim Yaghmour ([email protected])

Karim

include/asm-alpha/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_ALPHA_RELAY_H
+#define _ASM_ALPHA_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-arm/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_ARM_RELAY_H
+#define _ASM_ARM_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-arm26/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_ARM_RELAY_H
+#define _ASM_ARM_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-cris/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_CRIS_RELAY_H
+#define _ASM_CRIS_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-generic/relay.h +76 -0

76 lines not on this page · raw message

include/asm-h8300/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_H8300_RELAY_H
+#define _ASM_H8300_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-i386/relay.h +101 -0

101 lines not on this page · raw message

include/asm-ia64/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_IA64_RELAY_H
+#define _ASM_IA64_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-m68k/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_M68K_RELAY_H
+#define _ASM_M68K_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-m68knommu/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_M68KNOMMU_RELAY_H
+#define _ASM_M68KNOMMU_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-mips/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_RELAY_H
+#define _ASM_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-mips64/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_RELAY_H
+#define _ASM_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-parisc/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_PARISC_RELAY_H
+#define _ASM_PARISC_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-ppc/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_PPC_RELAY_H
+#define _ASM_PPC_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-ppc64/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_PPC64_RELAY_H
+#define _ASM_PPC64_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-s390/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_S390_RELAY_H
+#define _ASM_S390_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-sh/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_SH_RELAY_H
+#define _ASM_SH_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-sparc/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_SPARC_RELAY_H
+#define _ASM_SPARC_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-sparc64/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_SPARC64_RELAY_H
+#define _ASM_SPARC64_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-v850/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef __V850_RELAY_H
+#define __V850_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/asm-x86_64/relay.h +5 -0
@@ -0,0 +1,5 @@
+#ifndef _ASM_X86_64_RELAY_H
+#define _ASM_X86_64_RELAY_H
+
+#include <asm-generic/relay.h>
+#endif
include/linux/klog.h +24 -0
@@ -0,0 +1,24 @@
+/*
+ * KLOG		Generic Logging facility built upon the relayfs infrastructure
+ *
+ * Authors:	Hubertus Frankeh  ([email protected])
+ *		Tom Zanussi  ([email protected])
+ *
+ *		Please direct all questions/comments to [email protected]
+ *
+ *		Copyright (C) 2003, IBM Corp
+ *
+ *
+ *		This program is free software; you can redistribute it and/or
+ *		modify it under the terms of the GNU General Public License
+ *		as published by the Free Software Foundation; either version
+ *		2 of the License, or (at your option) any later version.
+ */
+
+#ifndef _LINUX_KLOG_H
+#define _LINUX_KLOG_H
+
+extern int klog(const char *fmt, ...);
+extern int klog_raw(const char *buf,int len);
+
+#endif	/* _LINUX_KLOG_H */
include/linux/relayfs_fs.h +689 -0

689 lines not on this page · raw message

#1 lore raw

include/linux/klog.h line 2

Quoted 5 lines · Karim Yaghmour
include/linux/klog.h +2 -0
@@ -0,0 +1,24 @@
+/*
+ * KLOG		Generic Logging facility built upon the relayfs infrastructure

Why is this header in the relayfs code? Shouldn't it be a separate patch?

thanks,

greg k-h

#2 lore raw
Quoted 11 lines · Greg KH

include/linux/klog.h line 2

Quoted 5 lines · Karim Yaghmour
include/linux/klog.h +2 -0
@@ -0,0 +1,24 @@
+/*
+ * KLOG		Generic Logging facility built upon the relayfs infrastructure

Why is this header in the relayfs code? Shouldn't it be a separate patch?

Yes, you're right - I'll separate it out.

Thanks,

Tom

Quoted 10 lines

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#3 lore raw
In reply to Karim Yaghmour
Quoted 5 lines · Karim Yaghmour
include/linux/relayfs_fs.h +5 -0
+/**
+ *	have_cmpxchg - does this architecture have a cmpxchg?
+ *
+ *	Returns 1 if this architecture has a cmpxchg useable by
+ *	the lockless scheme, 0 otherwise.

include/linux/relayfs_fs.h line 449

Quoted 10 lines
include/linux/relayfs_fs.h +10 -0
+ */
+static inline int
+have_cmpxchg(void)
+{
+#if defined(__HAVE_ARCH_CMPXCHG)
+	return 1;
+#else
+	return 0;
+#endif
+}

Shouldn't this be a build time check, and not a runtime one?

#4 lore raw
Quoted 12 lines · Greg KH
Quoted 10 lines · Karim Yaghmour
include/linux/relayfs_fs.h +10 -0
+/**
+ *	have_cmpxchg - does this architecture have a cmpxchg?
+ *
+ *	Returns 1 if this architecture has a cmpxchg useable by
+ *	the lockless scheme, 0 otherwise.
+ */
+static inline int
+have_cmpxchg(void)
+{
+#if defined(__HAVE_ARCH_CMPXCHG)
Quoted 9 lines

include/linux/relayfs_fs.h line 449

Quoted 5 lines
include/linux/relayfs_fs.h +5 -0
+	return 1;
+#else
+	return 0;
+#endif
+}

Shouldn't this be a build time check, and not a runtime one?

This was to avoid having an ifdef in the main body of the code. It's only used in channel setup, so I did'nt worrry about runtime checking.

Thanks,

Tom

Quoted 6 lines

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#5 lore raw
Quoted 23 lines · Tom Zanussi
Quoted 12 lines · Greg KH
Quoted 10 lines · Karim Yaghmour
include/linux/relayfs_fs.h +10 -0
+/**
+ *	have_cmpxchg - does this architecture have a cmpxchg?
+ *
+ *	Returns 1 if this architecture has a cmpxchg useable by
+ *	the lockless scheme, 0 otherwise.
+ */
+static inline int
+have_cmpxchg(void)
+{
+#if defined(__HAVE_ARCH_CMPXCHG)
Quoted 9 lines

include/linux/relayfs_fs.h line 449

Quoted 5 lines
include/linux/relayfs_fs.h +5 -0
+	return 1;
+#else
+	return 0;
+#endif
+}

Shouldn't this be a build time check, and not a runtime one?

Quoted 2 lines

This was to avoid having an ifdef in the main body of the code. It's only used in channel setup, so I did'nt worrry about runtime checking.

This should all be set up properly for you anyway. I don't think this is needed at all.

thanks,

greg k-h