Skip to contentSkip to conversation

scripts/reference*.pl - treat built-in.o as conglomerate

PATCH In review Keith Owens 2 participants 2 messages Jan 16, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts/reference*.pl - treat built-in.o as conglomerate

scripts/reference*.pl - treat built-in.o as conglomerate. Ignore references from altinstructions to init text/data.

scripts/reference_discarded.pl +1 -1
Index: 2.6.10/scripts/reference_discarded.pl
===================================================================
@@ -62,7 +62,7 @@ foreach $object (keys(%object)) {
 		$l = read(OBJECT, $comment, $size);
 		die "read $size bytes from $object .comment failed" if ($l != $size);
 		close(OBJECT);
-		if ($comment =~ /GCC\:.*GCC\:/m) {
+		if ($comment =~ /GCC\:.*GCC\:/m || $object =~ /built-in.\o/) {
 			++$ignore;
 			delete($object{$object});
 		}
scripts/reference_init.pl +2 -1
Index: 2.6.10/scripts/reference_init.pl
===================================================================
@@ -70,7 +70,7 @@ foreach $object (keys(%object)) {
 		$l = read(OBJECT, $comment, $size);
 		die "read $size bytes from $object .comment failed" if ($l != $size);
 		close(OBJECT);
-		if ($comment =~ /GCC\:.*GCC\:/m) {
+		if ($comment =~ /GCC\:.*GCC\:/m || $object =~ /built-in\.o/) {
 			++$ignore;
 			delete($object{$object});
 		}
@@ -96,6 +96,7 @@ foreach $object (sort(keys(%object))) {
 		     $from !~ /\.pci_fixup_header$/ &&
 		     $from !~ /\.pci_fixup_final$/ &&
 		     $from !~ /\__param$/ &&
+		     $from !~ /\.altinstructions/ &&
 		     $from !~ /\.debug_/)) {
 			printf("Error: %s %s refers to %s\n", $object, $from, $line);
 		}
#1 lore raw

Review

Quoted 6 lines · Keith Owens

scripts/reference*.pl - treat built-in.o as conglomerate. Ignore references from altinstructions to init text/data.

(quoted diff) +1 -0
+		if ($comment =~ /GCC\:.*GCC\:/m || $object =~ /built-in.\o/) {

s|built-in.\o|built-in\.o|

Corrected patch is attached.
---

scripts/reference*.pl - treat built-in.o as conglomerate. Ignore references from altinstructions to init text/data.

scripts/reference_discarded.pl +1 -1
Index: 2.6.10/scripts/reference_discarded.pl
===================================================================
@@ -62,7 +62,7 @@ foreach $object (keys(%object)) {
 		$l = read(OBJECT, $comment, $size);
 		die "read $size bytes from $object .comment failed" if ($l != $size);
 		close(OBJECT);
-		if ($comment =~ /GCC\:.*GCC\:/m) {
+		if ($comment =~ /GCC\:.*GCC\:/m || $object =~ /built-in\.o/) {
 			++$ignore;
 			delete($object{$object});
 		}
scripts/reference_init.pl +2 -1
Index: 2.6.10/scripts/reference_init.pl
===================================================================
@@ -70,7 +70,7 @@ foreach $object (keys(%object)) {
 		$l = read(OBJECT, $comment, $size);
 		die "read $size bytes from $object .comment failed" if ($l != $size);
 		close(OBJECT);
-		if ($comment =~ /GCC\:.*GCC\:/m) {
+		if ($comment =~ /GCC\:.*GCC\:/m || $object =~ /built-in\.o/) {
 			++$ignore;
 			delete($object{$object});
 		}
@@ -96,6 +96,7 @@ foreach $object (sort(keys(%object))) {
 		     $from !~ /\.pci_fixup_header$/ &&
 		     $from !~ /\.pci_fixup_final$/ &&
 		     $from !~ /\__param$/ &&
+		     $from !~ /\.altinstructions/ &&
 		     $from !~ /\.debug_/)) {
 			printf("Error: %s %s refers to %s\n", $object, $from, $line);
 		}

---