arlan: remove gcc warning with CONFIG_PROC_FS=n
Subsystems (3)
PATCH 1/1 arlan: remove gcc warning with CONFIG_PROC_FS=n
arlan: Fix gcc warning.
With CONFIG_PROC_FS=n, gcc complains:drivers/net/wireless/arlan-main.c:1858: warning: statement with no effect
diffstat:=
drivers/net/wireless/arlan.h | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
arlan: Fix gcc warning.
With CONFIG_PROC_FS=n, gcc complains:drivers/net/wireless/arlan-main.c:1858: warning: statement with no effect
diffstat:=
drivers/net/wireless/arlan.h | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/arlan.h renamed from drivers/net/wireless/arlan.h~arlan_procfs +1 -1
@@ -43,7 +43,7 @@extern int init_arlan_proc (void );extern void cleanup_arlan_proc (void );#else -#define init_arlan_proc () (0) +#define init_arlan_proc () ({ 0; })#define cleanup_arlan_proc () do { } while (0);#endif
PATCH 1/1 (v2) arlan: remove gcc warning with CONFIG_PROC_FS=n
Here's an update (as pointed out off-list). Please replace the first one if that works for you.
arlan: Fix gcc warning.
With CONFIG_PROC_FS=n, gcc complains:drivers/net/wireless/arlan-main.c:1858: warning: statement with no effect
Also remove a useless semi-colon on a #define.
diffstat:=
drivers/net/wireless/arlan.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/arlan.h renamed from drivers/net/wireless/arlan.h~arlan_procfs +2 -2
@@ -43,8 +43,8 @@extern int init_arlan_proc (void );extern void cleanup_arlan_proc (void );#else -#define init_arlan_proc () (0) -#define cleanup_arlan_proc () do { } while (0); +#define init_arlan_proc () ({ 0; }) +#define cleanup_arlan_proc () do { } while (0)#endif extern struct net_device *arlan_device[MAX_ARLANS ];
Re: [PATCH] (v2) arlan: remove gcc warning with CONFIG_PROC_FS=n
Quoted 9 lines · Randy.Dunlap
Here's an update (as pointed out off-list). Please replace the first one if that works for you.
arlan: Fix gcc warning.
With
CONFIG_PROC_FS=n, gcc complains:drivers/net/wireless/arlan-main.c:1858: warning: statement with no effect
Quoted 7 lines
Also remove a useless semi-colon on a #define.
Signed-off-by Randy Dunlap <[email protected]>diffstat:=
drivers/net/wireless/arlan.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
I've never touched that driver, but it looks ok to me. I hope
Jeff will pick it up.
Jean