Skip to contentSkip to conversation

Oops on killing process with soft-unmounted NFS3 krb5 mount

DISCUSSION Mark Goodman 2 participants 3 messages Jan 31, 2005 – Feb 1, 2005

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

I am running 2.6.11-rc2 with your patches. I recall this behavior on 2.6.8 as well.

I can consistently reproduce this oops on my Fedora Core 3 machine with the following steps:

Login as a normal user with a home directory on an NFS3 krb5 mount Login as root and run init 1. init 1 unmounts the mount. Kill the normal user's shell.

In practice, this often happens when switching to runlevel 6 for a reboot.

Jan 31 12:32:39 soda kernel: net/sunrpc/rpc_pipe.c: rpc_lookup_parent failed to find path /nfs/clnt0/krb5
Jan 31 12:32:39 soda kernel: Unable to handle kernel NULL pointer dereference at virtual address 0000005c
Jan 31 12:32:39 soda kernel:  printing eip:
Jan 31 12:32:39 soda kernel: f940ff40
Jan 31 12:32:39 soda kernel: *pde = 00000000
Jan 31 12:32:39 soda kernel: Oops: 0000 [#1]
Jan 31 12:32:39 soda kernel: Modules linked in: des nfs lockd md5 ipv6 parport_pc lp parport autofs4 rpcsec_gss_krb5 auth_rpcgss sunrpc video button battery ac uhci_hcd ehci_hcd snd_intel8x0 snd_ac97_codec snd_pcm_oss snd_mixer_oss snd_pcm snd_timer snd soundcore snd_page_alloc tg3 floppy dm_snapshot dm_zero dm_mirror ext3 jbd dm_mod ata_piix libata sd_mod scsi_mod
Jan 31 12:32:39 soda kernel: CPU:    0
Jan 31 12:32:39 soda kernel: EIP:    0060:[<f940ff40>]    Not tainted VLI
Jan 31 12:32:39 soda kernel: EFLAGS: 00010286   (2.6.11-rc2)
Jan 31 12:32:39 soda kernel: EIP is at gss_pipe_release+0x10/0x290 [auth_rpcgss]
Jan 31 12:32:39 soda kernel: eax: f58d1600   ebx: 00000000   ecx: 00000073   edx: f940ff30
Jan 31 12:32:39 soda kernel: esi: f5b46630   edi: f5b4604c   ebp: 00000000   esp: f5726d00
Jan 31 12:32:39 soda kernel: ds: 007b   es: 007b   ss: 0068
Jan 31 12:32:39 soda kernel: Process bash (pid: 4354, threadinfo=f5726000 task=f5674b30)
Jan 31 12:32:39 soda kernel: Stack: f5726d00 00000296 f504e800 f504e9c8 ffffffe0 00000000 f93d9126 f504e800
Jan 31 12:32:39 soda kernel:        f5b46630 f5b4604c 00000000 f93d92f9 f5b460ec f93d9d00 00000005 f5726d90
Jan 31 12:32:39 soda kernel:        f5498b2c 10ee271a f58d890c f5726000 00000001 f5b46630 f5b46268 f504ed00
Jan 31 12:32:39 soda kernel: Call Trace:
Jan 31 12:32:39 soda kernel:  [<f93d9126>] __rpc_purge_upcall+0xa6/0xb0 [sunrpc]
Jan 31 12:32:39 soda kernel:  [<f93d92f9>] rpc_close_pipes+0x89/0x90 [sunrpc]
Jan 31 12:32:39 soda kernel:  [<f93d9d00>] rpc_depopulate+0x280/0x410 [sunrpc]
Jan 31 12:32:39 soda kernel:  [<c018edcd>] cached_lookup+0x1d/0x80
Jan 31 12:32:39 soda kernel:  [<c0190aaf>] __lookup_hash+0x5f/0xb0
Jan 31 12:32:39 soda kernel:  [<f93da495>] rpc_rmdir+0x75/0xb0 [sunrpc]
Jan 31 12:32:39 soda kernel:  [<f941040d>] gss_destroy+0x2d/0x70 [auth_rpcgss]
Jan 31 12:32:39 soda kernel:  [<f93c44f4>] rpc_destroy_client+0x94/0xe0 [sunrpc]
Jan 31 12:32:39 soda kernel:  [<c0185ed7>] kill_anon_super+0x87/0x180
Jan 31 12:32:39 soda kernel:  [<f93c44dc>] rpc_destroy_client+0x7c/0xe0 [sunrpc]
Jan 31 12:32:39 soda kernel:  [<c019a139>] dput+0x109/0x680
Jan 31 12:32:39 soda kernel:  [<f95621d5>] nfs_kill_super+0x35/0x70 [nfs]
Jan 31 12:32:39 soda kernel:  [<c0183ed2>] deactivate_super+0xa2/0x120
Jan 31 12:32:39 soda kernel:  [<c0126393>] do_exit+0x623/0x670
Jan 31 12:32:39 soda kernel:  [<c0390396>] schedule_timeout+0xd6/0xe0
Jan 31 12:32:39 soda kernel:  [<c012645b>] do_group_exit+0x3b/0x1f0
Jan 31 12:32:39 soda kernel:  [<c0130123>] dequeue_signal+0x23/0xb0
Jan 31 12:32:39 soda kernel:  [<c01334ee>] get_signal_to_deliver+0x49e/0x7a0
Jan 31 12:32:39 soda kernel:  [<c025f827>] opost_block+0x97/0x140
Jan 31 12:32:39 soda kernel:  [<c01037df>] do_signal+0x8f/0x150
Jan 31 12:32:39 soda kernel:  [<c011d310>] default_wake_function+0x0/0x10
Jan 31 12:32:39 soda kernel:  [<c025aba5>] tty_write+0xb5/0x280
Jan 31 12:32:39 soda kernel:  [<c025aa6f>] tty_read+0xaf/0x130
Jan 31 12:32:39 soda kernel:  [<c017b9b5>] vfs_read+0xd5/0x170
Jan 31 12:32:39 soda kernel:  [<c0133b19>] sys_rt_sigprocmask+0x79/0x270
Jan 31 12:32:39 soda kernel:  [<c017bd01>] sys_read+0x41/0x70
Jan 31 12:32:39 soda kernel:  [<c01038d7>] do_notify_resume+0x37/0x3c
Jan 31 12:32:39 soda kernel:  [<c0103a1e>] work_notifysig+0x13/0x15
Jan 31 12:32:39 soda kernel: Code: 44 24 04 e8 d3 2a d1 c6 e9 57 fe ff ff 0f 0b e0 01 6c 47 41 f9 e9 82 fd ff ff 90 55 57 56 53 83 ec 1c 8b 80 bc 01 00 00 8b 58 1c <81> 7b 5c 3c 4b 24 1d 74 25 c7 04 24 14 48 41 f9 8d 43 5c be 04

-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#1 lore raw

må den 31.01.2005 Klokka 12:50 (-0800) skreiv Mark Goodman:

Quoted 6 lines

I am running 2.6.11-rc2 with your patches. I recall this behavior on 2.6.8 as well.

I can consistently reproduce this oops on my Fedora Core 3 machine with the following steps:

Quoted 8 lines

Login as a normal user with a home directory on an NFS3 krb5 mount Login as root and run init 1. init 1 unmounts the mount. Kill the normal user's shell.

In practice, this often happens when switching to runlevel 6 for a reboot.

Jan 31 12:32:39 soda kernel: net/sunrpc/rpc_pipe.c: rpc_lookup_parent 

failed to find path /nfs/clnt0/krb5

OK. Looks like kill_litter_super() might be the culprit here:
d_genocide() will give the above symptom. Does the appended patch work?

Cheers
Trond

Signature · 1 line
Trond Myklebust <[email protected]>

RPC: Fix an oopsable condition on detached mount of rpc_pipefs

---
 rpc_pipe.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
net/sunrpc/rpc_pipe.c +1 -1
Index: linux-2.6.11-rc2/net/sunrpc/rpc_pipe.c
===================================================================
@@ -795,7 +795,7 @@ static struct file_system_type rpc_pipe_
 	.owner		= THIS_MODULE,
 	.name		= "rpc_pipefs",
 	.get_sb		= rpc_get_sb,
-	.kill_sb	= kill_litter_super,
+	.kill_sb	= kill_anon_super,
 };
 
 static void
#2 lore raw

Nope. Here is the new (unchanged?) oops.

Jan 31 20:31:51 soda kernel: net/sunrpc/rpc_pipe.c: rpc_lookup_parent=20
failed to find path /nfs/clnt0/krb5
Jan 31 20:31:51 soda kernel: Unable to handle kernel NULL pointer=20
dereference at virtual address 0000005c
Jan 31 20:31:51 soda kernel:  printing eip:
Jan 31 20:31:51 soda kernel: f940ff40
Jan 31 20:31:51 soda kernel: *pde =3D 00000000
Jan 31 20:31:51 soda kernel: Oops: 0000 [#1]
Jan 31 20:31:51 soda kernel: Modules linked in: des nfs lockd parport_pc=20

lp parport autofs4 rpcsec_gss_krb5 auth_rpcgss sunrpc video button=20 battery ac md5 ipv6 uhci_hcd ehci_hcd snd_intel8x0 snd_ac97_codec=20 snd_pcm_oss snd_mixer_oss snd_pcm snd_timer snd soundcore snd_page_alloc=20 tg3 floppy dm_snapshot dm_zero dm_mirror ext3 jbd dm_mod ata_piix libata=20 sd_mod scsi_mod

Jan 31 20:31:51 soda kernel: CPU:    0
Jan 31 20:31:51 soda kernel: EIP:    0060:[<f940ff40>]    Not tainted VLI
Jan 31 20:31:51 soda kernel: EFLAGS: 00010286   (2.6.11-rc2)
Jan 31 20:31:51 soda kernel: EIP is at gss_pipe_release+0x10/0x290=20
[auth_rpcgss]
Jan 31 20:31:51 soda kernel: eax: f7321600   ebx: 00000000   ecx:=20
00000073   edx: f940ff30
Jan 31 20:31:51 soda kernel: esi: f66251d0   edi: f6663f4c   ebp:=20
00000000   esp: f6c92d00
Jan 31 20:31:51 soda kernel: ds: 007b   es: 007b   ss: 0068
Jan 31 20:31:51 soda kernel: Process bash (pid: 4336,=20
threadinfo=3Df6c92000 task=3Df64bd7b0)
Jan 31 20:31:51 soda kernel: Stack: f6c92d00 00000296 f74fd800 f74fd9c8=20
ffffffe0 00000000 f93d9126 f74fd800
Jan 31 20:31:51 soda kernel:        f66251d0 f6663f4c 00000000 f93d92f9=20
f666336c f93d9d00 00000005 f6c92d90
Jan 31 20:31:51 soda kernel:        f662f1ac 10ee271a f75039ac f6c92000=20
00000001 f66251d0 f6663d08 f74fdd00
Jan 31 20:31:51 soda kernel: Call Trace:
Jan 31 20:31:51 soda kernel:  [<f93d9126>] __rpc_purge_upcall+0xa6/0xb0=20
[sunrpc]
Jan 31 20:31:51 soda kernel:  [<f93d92f9>] rpc_close_pipes+0x89/0x90=20
[sunrpc]
Jan 31 20:31:51 soda kernel:  [<f93d9d00>] rpc_depopulate+0x280/0x410=20
[sunrpc]
Jan 31 20:31:51 soda kernel:  [<c018edcd>] cached_lookup+0x1d/0x80
Jan 31 20:31:51 soda kernel:  [<c0190aaf>] __lookup_hash+0x5f/0xb0
Jan 31 20:31:51 soda kernel:  [<f93da495>] rpc_rmdir+0x75/0xb0 [sunrpc]
Jan 31 20:31:51 soda kernel:  [<f941040d>] gss_destroy+0x2d/0x70=20
[auth_rpcgss]
Jan 31 20:31:51 soda kernel:  [<f93c44f4>] rpc_destroy_client+0x94/0xe0=20
[sunrpc]
Jan 31 20:31:51 soda kernel:  [<c0185ed7>] kill_anon_super+0x87/0x180
Jan 31 20:31:51 soda kernel:  [<f93c44dc>] rpc_destroy_client+0x7c/0xe0=20
[sunrpc]
Jan 31 20:31:51 soda kernel:  [<c019a139>] dput+0x109/0x680
Jan 31 20:31:51 soda kernel:  [<f954f1d5>] nfs_kill_super+0x35/0x70 [nfs]
Jan 31 20:31:51 soda kernel:  [<c0183ed2>] deactivate_super+0xa2/0x120
Jan 31 20:31:51 soda kernel:  [<c0126393>] do_exit+0x623/0x670
Jan 31 20:31:51 soda kernel:  [<c0390396>] schedule_timeout+0xd6/0xe0
Jan 31 20:31:51 soda kernel:  [<c0390396>] schedule_timeout+0xd6/0xe0
Jan 31 20:31:51 soda kernel:  [<c012645b>] do_group_exit+0x3b/0x1f0
Jan 31 20:31:51 soda kernel:  [<c0130123>] dequeue_signal+0x23/0xb0
Jan 31 20:31:51 soda kernel:  [<c01334ee>] get_signal_to_deliver+0x49e/0x=
7a0
Jan 31 20:31:51 soda kernel:  [<c025f827>] opost_block+0x97/0x140
Jan 31 20:31:51 soda kernel:  [<c01037df>] do_signal+0x8f/0x150
Jan 31 20:31:51 soda kernel:  [<c011d310>] default_wake_function+0x0/0x10
Jan 31 20:31:51 soda kernel:  [<c025aba5>] tty_write+0xb5/0x280
Jan 31 20:31:51 soda kernel:  [<c025aa6f>] tty_read+0xaf/0x130
Jan 31 20:31:51 soda kernel:  [<c017b9b5>] vfs_read+0xd5/0x170
Jan 31 20:31:51 soda kernel:  [<c0133b19>] sys_rt_sigprocmask+0x79/0x270
Jan 31 20:31:51 soda kernel:  [<c017bd01>] sys_read+0x41/0x70
Jan 31 20:31:51 soda kernel:  [<c01038d7>] do_notify_resume+0x37/0x3c
Jan 31 20:31:51 soda kernel:  [<c0103a1e>] work_notifysig+0x13/0x15
Jan 31 20:31:51 soda kernel: Code: 44 24 04 e8 d3 2a d1 c6 e9 57 fe ff=20

ff 0f 0b e0 01 6c 47 41 f9 e9 82 fd ff ff 90 55 57 56 53 83 ec 1c 8b 80=20 bc 01 00 00 8b 58 1c <81> 7b 5c 3c 4b 24 1d 74 25 c7 04 24 14 48 41 f9=20 8d 43 5c be 04

Mark

Quoted 7 lines · Trond Myklebust

m=E5 den 31.01.2005 Klokka 12:50 (-0800) skreiv Mark Goodman:
=20

Quoted 4 lines

I am running 2.6.11-rc2 with your patches. I recall this behavior on=20 2.6.8 as well.

I can consistently reproduce this oops on my Fedora Core 3 machine with=

=20

Quoted 7 lines
Quoted 7 lines

the following steps:

Login as a normal user with a home directory on an NFS3 krb5 mount Login as root and run init 1. init 1 unmounts the mount. Kill the normal user's shell.

In practice, this often happens when switching to runlevel 6 for a rebo=

ot.

Quoted 18 lines
Quoted 5 lines
Jan 31 12:32:39 soda kernel: net/sunrpc/rpc_pipe.c: rpc_lookup_parent=20

failed to find path /nfs/clnt0/krb5
=20

OK. Looks like kill_litter_super() might be the culprit here:
d_genocide() will give the above symptom. Does the appended patch work?

Cheers
Trond

=20

------------------------------------------------------------------------

RPC: Fix an oopsable condition on detached mount of rpc_pipefs

Quoted 7 lines

---
rpc_pipe.c | 2 +-

1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.11-rc2/net/sunrpc/rpc_pipe.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

Quoted 9 lines
net/sunrpc/rpc_pipe.c +1 -1
@@ -795,7 +795,7 @@ static struct file_system_type rpc_pipe_
 	.owner		=3D THIS_MODULE,
 	.name		=3D "rpc_pipefs",
 	.get_sb		=3D rpc_get_sb,
-	.kill_sb	=3D kill_litter_super,
+	.kill_sb	=3D kill_anon_super,
 };
Quoted 4 lines

=20
static void
=20

-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs