Skip to contentSkip to conversation

xio3130_downstream: Add ACS (Access Control Services) capability

PATCH In review Wang,Liang(ACG CCN01) 2 participants 2 messages May 16, 2022 – May 18, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xio3130_downstream: Add ACS (Access Control Services) capability

When vfio-pci devices are attached to the downstream, pcie acs

capability may be needed, Consistent with physical machine.

It has been tested in our environment, and pcie acs capability

is required in some scenarios.

---

 hw/pci-bridge/xio3130_downstream.c | 4 ++++
 1 file changed, 4 insertions(+)
hw/pci-bridge/xio3130_downstream.c +0 -0

index 05e2b06c0c..6ab13b47e2 100644

--- a/hw/pci-bridge/xio3130_downstream.c

+++ b/hw/pci-bridge/xio3130_downstream.c

@@ -40,6 +40,8 @@

#define XIO3130_SSVID_SSID 0

#define XIO3130_EXP_OFFSET 0x90

#define XIO3130_AER_OFFSET 0x100

+#define XIO3130_ACS_OFFSET \

+ (XIO3130_AER_OFFSET + PCI_ERR_SIZEOF)

static void xio3130_downstream_write_config(PCIDevice *d, uint32_t address,

uint32_t val, int len)

@@ -111,6 +113,8 @@ static void xio3130_downstream_realize(PCIDevice *d, Error **errp)

         goto err;

     }

+

+ pcie_acs_init(d, XIO3130_ACS_OFFSET);

     return;

err:

--

2.24.3 (Apple Git-128)

#1 lore raw

pin

Quoted 68 lines · On Mon, May 16, 2022 at 9:54 PM Wang,Liang(ACG CCN01) <[email protected]>…

When vfio-pci devices are attached to the downstream, pcie acs

capability may be needed, Consistent with physical machine.

It has been tested in our environment, and pcie acs capability

is required in some scenarios.

---

 hw/pci-bridge/xio3130_downstream.c | 4 ++++
 1 file changed, 4 insertions(+)
hw/pci-bridge/xio3130_downstream.c +0 -0

index 05e2b06c0c..6ab13b47e2 100644

--- a/hw/pci-bridge/xio3130_downstream.c

+++ b/hw/pci-bridge/xio3130_downstream.c

hw/pci-bridge/xio3130_downstream.c +2 -0
@@ -40,6 +40,8 @@
 
 #define XIO3130_SSVID_SSID              0
 
 #define XIO3130_EXP_OFFSET              0x90
 
 #define XIO3130_AER_OFFSET              0x100
 
+#define XIO3130_ACS_OFFSET \
 
+        (XIO3130_AER_OFFSET + PCI_ERR_SIZEOF)
 
 
 static void xio3130_downstream_write_config(PCIDevice *d, uint32_t

address,

uint32_t val, int len)

hw/pci-bridge/xio3130_downstream.c +2 -1
@@ -111,6 +113,8 @@ static void xio3130_downstream_realize(PCIDevice *d,
 Error **errp)
 
         goto err;
 
     }
 
 
+
 
+    pcie_acs_init(d, XIO3130_ACS_OFFSET);
 
     return;
 
 
 err:
 
--

2.24.3 (Apple Git-128)