Skip to contentSkip to conversation

btf: Add --btf_gen_all flag

PATCH In review Ilya Leoshkevich 2 participants 6 messages Mar 12, 2021 – Mar 23, 2021 BPF

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btf: Add --btf_gen_all flag

By default, pahole makes use only of BTF features introduced with kernel v5.2. Features that are added later need to be turned on with explicit feature flags, such as --btf_gen_floats. According to [1], this will hinder the people who generate BTF for kernels externally (e.g. for old kernels to support BPF CO-RE).

Introduce --btf_gen_all that allows using all BTF features supported by pahole.

[1] https://lore.kernel.org/dwarves/CAEf4Bzbyugfb2RkBkRuxNGKwSk40Tbq4zAvhQT8W=fVMYWuaxA@mail.gmail.com/

---
 man-pages/pahole.1 | 4 ++++
 pahole.c           | 8 ++++++++
 2 files changed, 12 insertions(+)
man-pages/pahole.1 +4 -0
index e292b2c..cbbefbf 100644
@@ -204,6 +204,10 @@ to "/sys/kernel/btf/vmlinux".
 Allow producing BTF_KIND_FLOAT entries in systems where the vmlinux DWARF
 information has float types.
 
+.TP
+.B \-\-btf_gen_all
+Allow using all the BTF features supported by pahole.
+
 .TP
 .B \-l, \-\-show_first_biggest_size_base_type_member
 Show first biggest size base_type member.
pahole.c +8 -0
index c8d38f5..df6aa83 100644
@@ -826,6 +826,7 @@ ARGP_PROGRAM_VERSION_HOOK_DEF = dwarves_print_version;
 #define ARGP_numeric_version       320
 #define ARGP_btf_base		   321
 #define ARGP_btf_gen_floats	   322
+#define ARGP_btf_gen_all	   323
 
 static const struct argp_option pahole__options[] = {
 	{
@@ -1125,6 +1126,11 @@ static const struct argp_option pahole__options[] = {
 		.key  = ARGP_btf_gen_floats,
 		.doc  = "Allow producing BTF_KIND_FLOAT entries."
 	},
+	{
+		.name = "btf_gen_all",
+		.key  = ARGP_btf_gen_all,
+		.doc  = "Allow using all the BTF features supported by pahole."
+	},
 	{
 		.name = "structs",
 		.key  = ARGP_just_structs,
@@ -1262,6 +1268,8 @@ static error_t pahole__options_parser(int key, char *arg,
 		print_numeric_version = true;		break;
 	case ARGP_btf_gen_floats:
 		btf_gen_floats = true;			break;
+	case ARGP_btf_gen_all:
+		btf_gen_floats = true;			break;
 	default:
 		return ARGP_ERR_UNKNOWN;
 	}
Signature · 1 line
2.29.2
#1 lore raw

Em Fri, Mar 12, 2021 at 01:08:08AM +0100, Ilya Leoshkevich escreveu:

Quoted 10 lines

By default, pahole makes use only of BTF features introduced with kernel v5.2. Features that are added later need to be turned on with explicit feature flags, such as --btf_gen_floats. According to [1], this will hinder the people who generate BTF for kernels externally (e.g. for old kernels to support BPF CO-RE).

Introduce --btf_gen_all that allows using all BTF features supported by pahole.

[1] https://lore.kernel.org/dwarves/CAEf4Bzbyugfb2RkBkRuxNGKwSk40Tbq4zAvhQT8W=fVMYWuaxA@mail.gmail.com/

Applied locally, testing ongoing.

Also added this:

- Arnaldo

Quoted 57 lines
---
 man-pages/pahole.1 | 4 ++++
 pahole.c           | 8 ++++++++
 2 files changed, 12 insertions(+)
man-pages/pahole.1 +4 -0
index e292b2c..cbbefbf 100644
@@ -204,6 +204,10 @@ to "/sys/kernel/btf/vmlinux".
 Allow producing BTF_KIND_FLOAT entries in systems where the vmlinux DWARF
 information has float types.
 
+.TP
+.B \-\-btf_gen_all
+Allow using all the BTF features supported by pahole.
+
 .TP
 .B \-l, \-\-show_first_biggest_size_base_type_member
 Show first biggest size base_type member.
pahole.c +8 -0
index c8d38f5..df6aa83 100644
@@ -826,6 +826,7 @@ ARGP_PROGRAM_VERSION_HOOK_DEF = dwarves_print_version;
 #define ARGP_numeric_version       320
 #define ARGP_btf_base		   321
 #define ARGP_btf_gen_floats	   322
+#define ARGP_btf_gen_all	   323
 
 static const struct argp_option pahole__options[] = {
 	{
@@ -1125,6 +1126,11 @@ static const struct argp_option pahole__options[] = {
 		.key  = ARGP_btf_gen_floats,
 		.doc  = "Allow producing BTF_KIND_FLOAT entries."
 	},
+	{
+		.name = "btf_gen_all",
+		.key  = ARGP_btf_gen_all,
+		.doc  = "Allow using all the BTF features supported by pahole."
+	},
 	{
 		.name = "structs",
 		.key  = ARGP_just_structs,
@@ -1262,6 +1268,8 @@ static error_t pahole__options_parser(int key, char *arg,
 		print_numeric_version = true;		break;
 	case ARGP_btf_gen_floats:
 		btf_gen_floats = true;			break;
+	case ARGP_btf_gen_all:
+		btf_gen_floats = true;			break;
 	default:
 		return ARGP_ERR_UNKNOWN;
 	}
Signature · 1 line
2.29.2
Signature · 1 line
- Arnaldo
#2 lore raw
Quoted 13 lines · Arnaldo Carvalho de Melo

Em Fri, Mar 12, 2021 at 01:08:08AM +0100, Ilya Leoshkevich escreveu:

Quoted 11 lines

By default, pahole makes use only of BTF features introduced with kernel v5.2. Features that are added later need to be turned on with explicit feature flags, such as --btf_gen_floats. According to [1], this will hinder the people who generate BTF for kernels externally (e.g. for old kernels to support BPF CO-RE).

Introduce --btf_gen_all that allows using all BTF features supported by pahole.

[1]
https://lore.kernel.org/dwarves/CAEf4Bzbyugfb2RkBkRuxNGKwSk40Tbq4zAvhQT8W=fVMYWuaxA@mail.gmail.com/

Quoted 7 lines

Applied locally, testing ongoing.

Also added this:

- Arnaldo

[...]

Hi Arnaldo,

I'd like to ping this patch (and
https://lore.kernel.org/dwarves/[email protected]/
too).

Best regards,
Ilya

Quoted 1 line
#3 lore raw

Em Tue, Mar 23, 2021 at 02:36:48PM +0100, Ilya Leoshkevich escreveu:

Quoted 22 lines · Arnaldo Carvalho de Melo
Quoted 13 lines

Em Fri, Mar 12, 2021 at 01:08:08AM +0100, Ilya Leoshkevich escreveu:

Quoted 11 lines

By default, pahole makes use only of BTF features introduced with kernel v5.2. Features that are added later need to be turned on with explicit feature flags, such as --btf_gen_floats. According to [1], this will hinder the people who generate BTF for kernels externally (e.g. for old kernels to support BPF CO-RE).

Introduce --btf_gen_all that allows using all BTF features supported by pahole.

[1]
https://lore.kernel.org/dwarves/CAEf4Bzbyugfb2RkBkRuxNGKwSk40Tbq4zAvhQT8W=fVMYWuaxA@mail.gmail.com/

Quoted 7 lines

Applied locally, testing ongoing.

Also added this:

- Arnaldo

Quoted 7 lines

[...]

Hi Arnaldo,

I'd like to ping this patch (and
https://lore.kernel.org/dwarves/[email protected]/
too).

So I finally finished testing, pushing out now.

- Arnaldo

#4 lore raw

Em Tue, Mar 23, 2021 at 03:07:23PM -0300, Arnaldo Carvalho de Melo escreveu:

Quoted 25 lines

Em Tue, Mar 23, 2021 at 02:36:48PM +0100, Ilya Leoshkevich escreveu:

Quoted 24 lines · Arnaldo Carvalho de Melo
Quoted 20 lines

Em Fri, Mar 12, 2021 at 01:08:08AM +0100, Ilya Leoshkevich escreveu:

Quoted 11 lines

By default, pahole makes use only of BTF features introduced with kernel v5.2. Features that are added later need to be turned on with explicit feature flags, such as --btf_gen_floats. According to [1], this will hinder the people who generate BTF for kernels externally (e.g. for old kernels to support BPF CO-RE).

Introduce --btf_gen_all that allows using all BTF features supported by pahole.

[1]
https://lore.kernel.org/dwarves/CAEf4Bzbyugfb2RkBkRuxNGKwSk40Tbq4zAvhQT8W=fVMYWuaxA@mail.gmail.com/

Applied locally, testing ongoing.

Also added this:

- Arnaldo

[...]

Quoted 7 lines
Quoted 5 lines

Hi Arnaldo,

I'd like to ping this patch (and
https://lore.kernel.org/dwarves/[email protected]/
too).

So I finally finished testing, pushing out now.

Please check what is in
https://git.kernel.org/pub/scm/devel/pahole/pahole.git/, I'm having some problems with 2FA on github, will fix soon.

- Arnaldo

#5 lore raw
Quoted 41 lines · Arnaldo Carvalho de Melo

Em Tue, Mar 23, 2021 at 03:07:23PM -0300, Arnaldo Carvalho de Melo escreveu:

Quoted 39 lines

Em Tue, Mar 23, 2021 at 02:36:48PM +0100, Ilya Leoshkevich escreveu:

Quoted 36 lines
Quoted 19 lines · Arnaldo Carvalho de Melo

Em Fri, Mar 12, 2021 at 01:08:08AM +0100, Ilya Leoshkevich escreveu:

Quoted 10 lines

By default, pahole makes use only of BTF features introduced with
kernel v5.2. Features that are added later need to be turned on with
explicit feature flags, such as --btf_gen_floats. According to [1],
this will hinder the people who generate BTF for kernels externally
(e.g. for old kernels to support BPF CO-RE).

Quoted 6 lines

Introduce --btf_gen_all that allows using all BTF features supported
by pahole.

[1]
https://lore.kernel.org/dwarves/CAEf4Bzbyugfb2RkBkRuxNGKwSk40Tbq4zAvhQT8W=fVMYWuaxA@mail.gmail.com/

Quoted 7 lines

Applied locally, testing ongoing.

Also added this:

- Arnaldo

[...]

Hi Arnaldo,

I'd like to ping this patch (and
https://lore.kernel.org/dwarves/[email protected]/
too).

Quoted 8 lines
Quoted 1 line

So I finally finished testing, pushing out now.

Please check what is in
https://git.kernel.org/pub/scm/devel/pahole/pahole.git/, I'm having some
problems with 2FA on github, will fix soon.

- Arnaldo

That looks good, thanks!

s390 seems to run fine again with the latest bpf-next / llvm / pahole. Now I can finally give adding s390 to the libbpf CI another try :-)