Skip to contentSkip to conversation

Resend: sym53c8xx.c: Add ULL suffix to fix warning

PATCH In review Mark F. Haigh 1 participant 3 messages Feb 8, 2005 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Resend: sym53c8xx.c: Add ULL suffix to fix warning

Same patch, now against 2.4.29-bk8:

Noticed that in drivers/scsi/sym53c8xx.c:

sym53c8xx.c:13185: warning: integer constant is too large for "long" type

Since we're not dealing with C99 (yet), this 64 bit integer constant needs to be suffixed with ULL. Patch included.

Mark F. Haigh
[email protected]

scsi/sym53c8xx.c renamed from scsi/sym53c8xx.c.orig +1 -1
@@ -13182,7 +13182,7 @@
 	** descriptors.
 	*/
 	if (chip && (chip->features & FE_DAC)) {
-		if (pci_set_dma_mask(pdev, (u64) 0xffffffffff))
+		if (pci_set_dma_mask(pdev, (u64) 0xffffffffffULL))
 			chip->features &= ~FE_DAC_IN_USE;
 		else
 			chip->features |= FE_DAC_IN_USE;
#1 lore raw

scsi/sym53c8xx.c

Quoted 3 lines · Mark F. Haigh
scsi/sym53c8xx.c renamed from scsi/sym53c8xx.c.orig +0 -0

Apologies. Patch now -p1-able.

Mark F. Haigh
[email protected]

drivers/scsi/sym53c8xx.c renamed from drivers/scsi/sym53c8xx.c.orig +1 -1
@@ -13182,7 +13182,7 @@
 	** descriptors.
 	*/
 	if (chip && (chip->features & FE_DAC)) {
-		if (pci_set_dma_mask(pdev, (u64) 0xffffffffff))
+		if (pci_set_dma_mask(pdev, (u64) 0xffffffffffULL))
 			chip->features &= ~FE_DAC_IN_USE;
 		else
 			chip->features |= FE_DAC_IN_USE;
#2 lore raw
Quoted 3 lines · Mark F. Haigh

Apologies. Patch now -p1-able.

[Apolgies yet again, description included now]

Noticed that in drivers/scsi/sym53c8xx.c:

sym53c8xx.c:13185: warning: integer constant is too large for "long" type

Since we're not dealing with C99 (yet), this 64 bit integer constant needs to be suffixed with ULL. Patch included.

Mark F. Haigh
[email protected]

drivers/scsi/sym53c8xx.c renamed from drivers/scsi/sym53c8xx.c.orig +1 -1
@@ -13182,7 +13182,7 @@
 	** descriptors.
 	*/
 	if (chip && (chip->features & FE_DAC)) {
-		if (pci_set_dma_mask(pdev, (u64) 0xffffffffff))
+		if (pci_set_dma_mask(pdev, (u64) 0xffffffffffULL))
 			chip->features &= ~FE_DAC_IN_USE;
 		else
 			chip->features |= FE_DAC_IN_USE;