Skip to contentSkip to conversation

allow fb_find_mode() w/ default db from modules

PATCH In review David Vrabel 2 participants 2 messages Feb 10, 2005 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 allow fb_find_mode() w/ default db from modules

Remove the __init from modedb in modedb.c so it can be used from modules as the default db in fb_find_mode().

Signed-off-by David Vrabel

Index: linux-2.6-i386/drivers/video/modedb.c
===================================================================
--- linux-2.6-i386.orig/drivers/video/modedb.c 2005-02-10
15:54:58.682358203 +0000
+++ linux-2.6-i386/drivers/video/modedb.c 2005-02-10 15:57:29.956725460
+0000
@@ -39,7 +39,7 @@

#define DEFAULT_MODEDB_INDEX 0

-static const __init struct fb_videomode modedb[] = {

+static const struct fb_videomode modedb[] = {
     {

/* 640x400 @ 70 Hz, 31.5 kHz hsync */ NULL, 70, 640, 400, 39721, 40, 24, 39, 9, 96, 2,

Signature · 11 lines
David Vrabel, Design Engineer

Arcom, Clifton Road           Tel: +44 (0)1223 411200 ext. 3233
Cambridge CB1 7EA, UK         Web: http://www.arcom.com/


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
#1 lore raw

Is there any reason why this has been originally flagged "__init"? "vesa_modes" is not "__init". That's why I changed "intelfb" to use "vesa_modes".

--Axel

Quoted 12 lines · David Vrabel

Remove the __init from modedb in modedb.c so it can be used from modules as the default db in fb_find_mode().

Signed-off-by David Vrabel

Index: linux-2.6-i386/drivers/video/modedb.c
===================================================================
--- linux-2.6-i386.orig/drivers/video/modedb.c 2005-02-10
15:54:58.682358203 +0000
+++ linux-2.6-i386/drivers/video/modedb.c 2005-02-10 15:57:29.956725460
+0000

Review line 45

Quoted 8 lines
(quoted diff) +1 -1
@@ -39,7 +39,7 @@
 
 #define DEFAULT_MODEDB_INDEX	0
 
-static const __init struct fb_videomode modedb[] = {
+static const struct fb_videomode modedb[] = {
     {
 	/* 640x400 @ 70 Hz, 31.5 kHz hsync */
 	NULL, 70, 640, 400, 39721, 40, 24, 39, 9, 96, 2,

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click