libata: update ATA pass thru opcodes]

I thought the "Command sets are supposed to be qualified" paragraph was worth forwarding to linux-scsi.

Jeff

------------------------------------------------------------------------

Subject:
[patch libata-dev-2.6 5/5] libata: update ATA pass thru opcodes From:
"John W. Linville" <[email protected]>
Date:
Fri, 18 Feb 2005 15:16:23 -0500
To:
[email protected], [email protected], [email protected]

To:
[email protected], [email protected], [email protected]

Update ATA pass thru opcodes to match what is specified in the current ATA pass thru spec (T10/04-262r7).

Signed-off-by John W. Linville <[email protected]>

---
This part was controversial before, because these opcodes seemed to overlap with some existing opcodes. So I contacted the author of the spec, Curtis Stevens: (quoted without permision)

"The command values in 04-262r7 are correct. There was an erroneous value published in the minutes that subsequently got published in SPC. This has been corrected.

Command sets are supposed to be qualified by the Inquiry Peripheral Device Type. I am a little concerned that some portions of linux depend on opcodes being the same for all PDTs. Using reusing opcodes will continue to happen more frequently as new applications emerge and new devices are created. The SCSI opcoded are already overloaded to the point that Service Actions have become necessary to extend the protocol."

Honestly, I don't know if that clears things up or not. But, Curtis seems pretty adamant that the values in the patch below (which match rev 7 of the spec) are correct. IMHO, at worst these values are no more wrong than the ones already there.

So, apply this now, or apply it later... :-)

 include/scsi/scsi.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

include/scsi/scsi.h renamed from include/scsi/scsi.h.orig +0 -0

@@ -113,9 +113,9 @@ extern const char *const scsi_device_typ
 /* values for service action in */
 #define	SAI_READ_CAPACITY_16  0x10