PATCH: add ppc PVR register values for 7447A and 7457 CPUs
Trivial patch to add 7447A and 7457 CPU defs.
# This is a BitKeeper generated diff -Nru style patch. #
# ChangeSet
# 2005/02/23 16:17:49+00:00 [email protected]
# Add ppc PVR definitions for 7447A and 7457 CPUs.
#
# include/asm-ppc/reg.h # 2005/02/23 16:17:40+00:00 [email protected] +2 -0 # Add ppc PVR definitions for 7447A and 7457 CPUs. # diff -Nru a/include/asm-ppc/reg.h b/include/asm-ppc/reg.h --- a/include/asm-ppc/reg.h 2005-02-23 16:18:45 +00:00 +++ b/include/asm-ppc/reg.h 2005-02-23 16:18:45 +00:00 @@ -471,7 +471,9 @@ #define PVR_750P PVR_740P #define PVR_7400 0x000C0000 #define PVR_7410 0x800C0000 +#define PVR_7447A 0x80030000 #define PVR_7450 0x80000000 +#define PVR_7457 0x80020000 #define PVR_8540 0x80200000 #define PVR_8560 0x80200000 /*
Quoted 3 lines · James Chapman
Signed-off-by James Chapman <[email protected]>Trivial patch to add 7447A and 7457 CPU defs.
Why? Most of the PVR definitions here can be removed (*muttering about 85xx ones being added).
Signature · 2 lines
Tom Rini http://gate.crashing.org/~trini/
Quoted 6 lines · Tom Rini
Quoted 3 lines · James Chapman
Signed-off-by James Chapman <[email protected]>Trivial patch to add 7447A and 7457 CPU defs.
Why?=A0 Most of the PVR definitions here can be removed (*muttering =
about
Quoted 1 line
85xx ones being added).
Yeah, yeah, will work on removing them.
- kumar
Tom,
Here are the only usages of PVR_<CPU> that are in arch/ppc:
boot/simple/misc-ev64260.S: cmplwi r25,(PVR_7450 >> 16)
platforms/ev64260.c: if (pvr !=3D PVR_VER(PVR_7450)) {
platforms/4xx/ebony.c: case PVR_REV(PVR_440GP_RB):
platforms/4xx/ebony.c: case PVR_REV(PVR_440GP_RC1):
syslib/ibm440gx_common.c: if (pvr =3D=3D PVR_440GX_RA || pvr =3D=3D=20=PVR_440GX_RB ||syslib/ibm440gx_common.c: (pvr =3D=3D PVR_440GX_RC && p->cpu >=20=
667000000))
What do you think should we just get ride of all the other cases that=20 are not actually used and leave these in asm/regs.h or should we move=20 them as follows:
PVR_7450 -> into platforms/ev64260.h
PVR_440GP* -> into platforms/4xx/ebony.c (or include/asm/ibm4xx.h) PVR_440GX* -> into syslib/ibm440gx_common.h
- kumar
Quoted 22 lines · Kumar Gala
Quoted 6 lines · Tom Rini
On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:
=A0 > Signed-off-by: James Chapman <[email protected]>Quoted 2 lines
Trivial patch to add 7447A and 7457 CPU defs.
Why?=A0 Most of the PVR definitions here can be removed (*muttering=20=
about
Quoted 1 line
=A0 85xx ones being added).
Yeah, yeah, will work on removing them.
- kumar
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Quoted 10 lines · Tom Rini
Quoted 3 lines · James Chapman
Signed-off-by James Chapman <[email protected]>Trivial patch to add 7447A and 7457 CPU defs.
Why? Most of the PVR definitions here can be removed (*muttering about 85xx ones being added).
I'm in the process of submitting a patch for a new board (Radstone PPC7D). Since other boards test CPU type using definitions in this file, I was trying to be consistent.
If the community don't think those definitions are useful, I'll just move the ones I need into my board support stuff.
Signature · 2 lines
James Chapman PGP key : http://www.katalix.com/~jchapman/pgpkey.txt
Quoted 13 lines · James Chapman
Quoted 10 lines · Tom Rini
Quoted 3 lines · James Chapman
Signed-off-by James Chapman <[email protected]>Trivial patch to add 7447A and 7457 CPU defs.
Why? Most of the PVR definitions here can be removed (*muttering about 85xx ones being added).
Quoted 6 lines
I'm in the process of submitting a patch for a new board (Radstone PPC7D). Since other boards test CPU type using definitions in this file, I was trying to be consistent.
If the community don't think those definitions are useful, I'll just move the ones I need into my board support stuff.
Is there something you can't get from cur_cpu_spec[0] ? That's why all of the PVR definitions _should_ be unneeded now.
Signature · 2 lines
Tom Rini http://gate.crashing.org/~trini/
Quoted 2 lines · Tom Rini
Is there something you can't get from cur_cpu_spec[0] ? That's why all of the PVR definitions _should_ be unneeded now.
No, I'll use cur_cpu_spec[]. Thanks
Signature · 2 lines
James Chapman PGP key : http://www.katalix.com/~jchapman/pgpkey.txt