Skip to contentSkip to conversation

AHCI: print port ID not number

PATCH In review Brett Russ 2 participants 2 messages Feb 24, 2005

Subsystems (2)
lore
Share & tools
lore

Brett Russ

author
#0 lore raw

PATCH 1/1 AHCI: print port ID not number

The attached patch fixes the "ata#: error occurred, port reset" line to display the port id instead of the port number.

drivers/scsi/ahci.c Thu Feb 24 14:21:41 2005 renamed from drivers/scsi/ahci.c Thu Feb 24 14:18:35 2005 +1 -1
@@ -574,7 +574,7 @@
        writel(tmp, port_mmio + PORT_CMD);
        readl(port_mmio + PORT_CMD); /* flush */
 
-       printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->port_no);
+       printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->id);
 }
 
 static void ahci_eng_timeout(struct ata_port *ap)
#1 lore raw
Quoted 10 lines · Brett Russ

The attached patch fixes the "ata#: error occurred, port reset" line to display the port id instead of the port number.

------------------------------------------------------------------------

drivers/scsi/ahci.c Thu Feb 24 14:21:41 2005 line 577

Quoted 5 lines
drivers/scsi/ahci.c Thu Feb 24 14:21:41 2005 renamed from drivers/scsi/ahci.c Thu Feb 24 14:18:35 2005 +1 -1
@@ -574,7 +574,7 @@
        writel(tmp, port_mmio + PORT_CMD);
        readl(port_mmio + PORT_CMD); /* flush */
 
-       printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->port_no);
+       printk(KERN_WARNING "ata%u: error occurred, port reset\n", ap->id);

Your patch is corrupted, as <something> converted tabs to spaces.

I highly recommend finding a Unix machine with sendmail, and sending patches like this:

The ideal is an inline patch, rather than an attachment anyway. e.g.

To: ...
From: ...
Subject: ...
<blank line>
Patch description
Patch

cat'd to 'sendmail -t'. Sendmail (or another MTA which provides a /usr/sbin/sendmail wrapper) will automatically fill in other headers like Message-ID and Date.

Jeff