Skip to contentSkip to conversation

fix ext2load failing on devices other than 0

PATCH New Andrew Dyer 3 participants 4 messages Mar 1, 2005

lore
Share & tools
lore

Andrew Dyer

author
#0 lore raw

PATCH 1/1 fix ext2load failing on devices other than 0

CHANGELOG:
* Patch by Andrew Dyer, 28 February 2005:
fix where ext2load command passed incorrect pointer to get_partition_info() resulting in load failure for devices other than 0

Signature · 19 lines
Hardware, n.:
        The parts of a computer system that can be kicked.
-------------- next part --------------
Index: common/cmd_ext2.c
===================================================================
RCS file: /cvsroot/u-boot/u-boot/common/cmd_ext2.c,v
retrieving revision 1.2
diff -p -u -r1.2 cmd_ext2.c
--- common/cmd_ext2.c	4 Feb 2005 15:02:08 -0000	1.2
+++ common/cmd_ext2.c	1 Mar 2005 01:19:14 -0000
@@ -223,7 +223,7 @@ int do_ext2load (cmd_tbl_t *cmdtp, int f
 	PRINTF("Using device %s%d, partition %d\n", argv[1], dev, part);
 
 	if (part != 0) {
-		if (get_partition_info (&dev_desc[dev], part, &info)) {
+		if (get_partition_info (dev_desc, part, &info)) {
 			printf ("** Bad partition %d **\n", part);
 			return(1);
 		}
#1 lore raw

PATCH 1/1 fix ext2load failing on devices other than 0

Hello,

then the same bug may also be in "cmd_reiser.c".

Reinhard

Quoted 27 lines · Andrew Dyer

CHANGELOG:
* Patch by Andrew Dyer, 28 February 2005:
fix where ext2load command passed incorrect pointer to get_partition_info() resulting in load failure for devices other than 0

------------------------------------------------------------------------

Index: common/cmd_ext2.c
===================================================================
RCS file: /cvsroot/u-boot/u-boot/common/cmd_ext2.c,v retrieving revision 1.2
diff -p -u -r1.2 cmd_ext2.c

cmd_ext2.c +1 -1
@@ -223,7 +223,7 @@ int do_ext2load (cmd_tbl_t *cmdtp, int f
 	PRINTF("Using device %s%d, partition %d\n", argv[1], dev, part);
 
 	if (part != 0) {
-		if (get_partition_info (&dev_desc[dev], part, &info)) {
+		if (get_partition_info (dev_desc, part, &info)) {
 			printf ("** Bad partition %d **\n", part);
 			return(1);
 		}
#2 lore raw

PATCH 1/1 fix ext2load failing on devices other than 0

Quoted 2 lines · In message <[email protected]> you wrote:

then the same bug may also be in "cmd_reiser.c".

Indeed. And in some other files, too. Fixed.

Thanks for pointing out.

Best regards,

Wolfgang Denk

Signature · 6 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Severe culture shock results when experts from another protocol suite
[...] try to read OSI documents. The term "osified" is used to  refer
to  such  documents. [...] Any relationship to the word "ossified" is
purely intentional.                                - Marshall T. Rose
#3 lore raw

PATCH 1/1 fix ext2load failing on devices other than 0

In reply to Andrew Dyer
Quoted 5 lines · In message <[email protected]> you wrote:

* Patch by Andrew Dyer, 28 February 2005:
fix where ext2load command passed incorrect pointer to get_partition_info() resulting in load failure for devices other than 0

Thanks for pointing out - checked in.

Best regards,

Wolfgang Denk

Signature · 6 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Get back to your stations!"
"We're beaming down to the planet, sir."
	-- Kirk and Mr. Leslie, "This Side of Paradise",
	   stardate 3417.3