Skip to contentSkip to conversation

compilation failure due to confliction of time_offset

PATCH In review Takeharu KATO 3 participants 3 messages Mar 12, 2005 – Mar 17, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 compilation failure due to confliction of time_offset

Hi all:

I send carbon copy of the mail to maintainers of Embedded PowerPC, because I can not figure out who is responsible for arch/ppc/kernel/time.c.

I found a trivial bug made compilation fail.
I show error log as follows:

-- error log
arch/ppc/kernel/time.c:92: error: static declaration of 'time_offset' follows non-static declaration
include/linux/timex.h:236: error: previous declaration of 'time_offset' was heremake[1]: *** [arch/ppc/kernel/time.o] Error 1
make: *** [arch/ppc/kernel] Error 2
--

Please apply following patch if this is a correct fix.

Regards,

Signature · 14 lines
Takeharu KATO

Signed-off-by: Takeharu KATO <[email protected]>

--- linux-2.6.11.maybe/arch/ppc/kernel/time.c   2005-03-05
23:58:20.000000000 +0900
+++ linux-2.6.11/arch/ppc/kernel/time.c 2005-03-13 00:46:49.000000000 +0900
@@ -89,7 +89,6 @@ unsigned long tb_to_ns_scale;

 extern unsigned long wall_jiffies;

-static long time_offset;

 DEFINE_SPINLOCK(rtc_lock);
#1 lore raw
Quoted 8 lines · Takeharu KATO

Hi all:

I send carbon copy of the mail to maintainers of Embedded PowerPC, because I can not figure out who is responsible for arch/ppc/kernel/time.c.

I found a trivial bug made compilation fail.
I show error log as follows:

Quoted 6 lines

-- error log
arch/ppc/kernel/time.c:92: error: static declaration of 'time_offset' follows non-static declaration
include/linux/timex.h:236: error: previous declaration of 'time_offset' was heremake[1]: *** [arch/ppc/kernel/time.o] Error 1
make: *** [arch/ppc/kernel] Error 2

Are you certain that the 'time_offset' referenced in <linux/timex.h> is what wants to be used in arch/ppc/kernel/time.c ? Thanks.

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/
#2 lore raw

Tom:

Sorry, I did misunderstand about it.
I'll fix this if nobody is working on this problem.

Quoted 5 lines · Tom Rini

Are you certain that the 'time_offset' referenced in <linux/timex.h> is what wants to be used in arch/ppc/kernel/time.c ? Thanks.

Signature · 3 lines
Takeharu KATO
Fujitsu Limited
Email:kato.takeharu at jp.fujitsu.com