Skip to contentSkip to conversation

nwflash: use no_seek_end_llseek_size

PATCH In review Arnd Bergmann 2 participants 2 messages Dec 9, 2015

Subsystems (2)
lore
Share & tools
lore

Arnd Bergmann

author maintainer
#0 lore raw

PATCH 1/1 nwflash: use no_seek_end_llseek_size

The recently introduced no_seek_end_llseek was wrong, it should be no_seek_end_llseek_size:

drivers/char/nwflash.c: In function 'flash_llseek':
drivers/char/nwflash.c:280:8: error: too many arguments to function 'no_seek_end_llseek'

Fixes 00c1b53c0e61 ("new helpers: no_seek_end_llseek{,_size}()")
drivers/char/nwflash.c +1 -1
index 362fb1e230e3..dbe598de9b74 100644
@@ -277,7 +277,7 @@ static loff_t flash_llseek(struct file *file, loff_t offset, int orig)
 		printk(KERN_DEBUG "flash_llseek: offset=0x%X, orig=0x%X.\n",
 		       (unsigned int) offset, orig);
 
-	ret = no_seek_end_llseek(file, offset, orig, gbFlashSize);
+	ret = no_seek_end_llseek_size(file, offset, orig, gbFlashSize);
 	mutex_unlock(&flash_mutex);
 	return ret;
 }
maintainer
#1 lore raw
Quoted 5 lines · Arnd Bergmann

The recently introduced no_seek_end_llseek was wrong, it should be no_seek_end_llseek_size:

drivers/char/nwflash.c: In function 'flash_llseek':
drivers/char/nwflash.c:280:8: error: too many arguments to function 'no_seek_end_llseek'

Folded and pushed.