Skip to contentSkip to conversation

af_key: broken error handling in pfkey_xfrm_state2msg()

PATCH New Ollie Wild 1 participant 1 message Mar 17, 2005

lore
Share & tools
lore

Ollie Wild

author
#0 lore raw

PATCH 1/1 af_key: broken error handling in pfkey_xfrm_state2msg()

Hi,

The pfkey_xfrm_state2msg() was missing a return in an EINVAL statement. This patch resolves the problem.

Please cc my address on any replies, as I am not on the linux kernel mailing list.

Ollie

Fixes broken error handling in pfkey_xfrm_state2msg().

key/af_key.c renamed from key/af_key.c.orig +1 -1
@@ -598,7 +598,7 @@
 	/* address family check */
 	sockaddr_size = pfkey_sockaddr_size(x->props.family);
 	if (!sockaddr_size)
-		ERR_PTR(-EINVAL);
+		return ERR_PTR(-EINVAL);
 
 	/* base, SA, (lifetime (HSC),) address(SD), (address(P),)
 	   key(AE), (identity(SD),) (sensitivity)> */