Skip to contentSkip to conversation

2.6.12-rc1-mm1

DISCUSSION Oleg Nesterov 2 participants 2 messages Mar 21, 2005 – Mar 22, 2005

lore
Share & tools
lore
#0 lore raw

Not related to this mm release directly, but

Quoted 4 lines

All 609 patches:
...
x86-fix-esp-corruption-cpu-bug-take-2.patch
x86: fix ESP corruption CPU bug (take 2)

I think that Stas tries to steal 1024 bytes from kernel's memory ... On top of his patch.

arch/i386/kernel/cpu/common.c renamed from arch/i386/kernel/cpu/common.c~stas +0 -1
@@ -21,7 +21,6 @@
 DEFINE_PER_CPU(struct desc_struct, cpu_gdt_table[GDT_ENTRIES]);
 EXPORT_PER_CPU_SYMBOL(cpu_gdt_table);
 
-unsigned char cpu_16bit_stack[CPU_16BIT_STACK_SIZE];
 DEFINE_PER_CPU(unsigned char, cpu_16bit_stack[CPU_16BIT_STACK_SIZE]);
 EXPORT_PER_CPU_SYMBOL(cpu_16bit_stack);
 
include/asm-i386/desc.h renamed from include/asm-i386/desc.h~stas +0 -1
@@ -17,7 +17,6 @@
 extern struct desc_struct cpu_gdt_table[GDT_ENTRIES];
 DECLARE_PER_CPU(struct desc_struct, cpu_gdt_table[GDT_ENTRIES]);
 
-extern unsigned char cpu_16bit_stack[CPU_16BIT_STACK_SIZE];
 DECLARE_PER_CPU(unsigned char, cpu_16bit_stack[CPU_16BIT_STACK_SIZE]);
 
 struct Xgt_desc_struct {
#1 lore raw

Hi,

Quoted 2 lines · Oleg Nesterov
Quoted 1 line

x86: fix ESP corruption CPU bug (take 2)

I think that Stas tries to steal 1024 bytes from kernel's memory ...

I think so too, sorry.
I simply copied that from the cpu_gdt_table
definition, and here's the mistake :(
Probably this:
---

$ nm -g vmlinux |grep cpu_gdt_table
c02d7000 D cpu_gdt_table
c037c300 D per_cpu__cpu_gdt_table
---
can be optimized too?