input/joystick/gamecon: Adjustments for gc_attach()
Subsystems (3)
cover input/joystick/gamecon: Adjustments for gc_attach()
From: Markus Elfring <[email protected]>
Date: Sat, 27 Jan 2018 17:07:27 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation Improve a size determination
drivers/input/joystick/gamecon.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Signature · 1 line
2.16.1
PATCH 1/2 Input: gamecon: Delete an error message for a failed memory allocation in gc_attach()
From: Markus Elfring <[email protected]>
Date: Sat, 27 Jan 2018 16:27:11 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
--- drivers/input/joystick/gamecon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/input/joystick/gamecon.c +1 -3
@@ -966,10 +966,8 @@ static void gc_attach(struct parport *pp) } gc =kzalloc (sizeof (struct gc ),GFP_KERNEL ); -if (!gc) { -pr_err ("Not enough memory\n" ); +if (!gc) goto err_unreg_pardev; - }mutex_init (&gc->mutex); gc->pd = pd;
Signature · 1 line
2.16.1
PATCH 2/2 Input: gamecon: Improve a size determination in gc_attach()
In reply to SF Markus ElfringFrom: Markus Elfring <[email protected]>
Date: Sat, 27 Jan 2018 16:30:58 +0100
Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
--- drivers/input/joystick/gamecon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/joystick/gamecon.c +1 -1
@@ -965,7 +965,7 @@ static void gc_attach(struct parport *pp)return ; } - gc =kzalloc (sizeof (struct gc ),GFP_KERNEL ); + gc =kzalloc (sizeof (*gc),GFP_KERNEL );if (!gc) goto err_unreg_pardev;
Signature · 1 line
2.16.1