Second Eth enabled for MPC885ADS
PATCH 1/1 Second Eth enabled for MPC885ADS
Wolfgang, can you check this in please?
We need this patch for MPC885ADS board: there are two Ethernet ports that can operate simultaneously, thus we need U-Boot to pass two MAC addresses to the Linux kernel.
Attached a patch which enables the second Ethernet address in the MPC885ADS config.
Patch made against current CVS.
CHANGELOG:
* Second Ethernet address enabled in the configuration for MPC885ADS.
--
Sincerely, Vitaly
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 885.diff
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050330/8bda41b9/attachment.txt
PATCH 1/1 Second Eth enabled for MPC885ADS
Dear Vitaly,
Quoted 2 lines · in message <[email protected]> you wrote:
Wolfgang, can you check this in please?
I can, but I don't want to :-)
Quoted 2 lines
CHANGELOG:
* Second Ethernet address enabled in the configuration for MPC885ADS.
...
Review
Quoted 3 lines
(quoted diff) +3
-0+#define CONFIG_ETHADDR 00:e0:0c:bc:e0:60 +#define CONFIG_HAS_ETH1 +#define CONFIG_ETH1ADDR 00:e0:0c:bc:e0:61
Adding CONFIG_HAS_ETH1 is OK with me, but I think it is a very bad idea to hardwire the MAC addresses - especially since this is write-protected. You will not be able to ever use two such boards in the same network.
I suggest to resubmit without the CONFIG_ETH*ADDR settings.
Best regards,
Wolfgang Denk
Signature · 3 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Lots of folks confuse bad management with destiny. -- Frank Hubbard