Skip to contentSkip to conversation

I2C rtc8564.c remove duplicate include (fixed)

PATCH Applied Clemens Koller 3 participants 5 messages Apr 4, 2005 – May 2, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 I2C rtc8564.c remove duplicate include (fixed)

[PATCH] I2C rtc8564.c remove duplicate include

Trivial fix: removes duplicate include line.

Patch applies to: 2.6.11.x

(This is my very first patch to the linux-kernel, so let me start with small things first...)

drivers/i2c/chips/rtc8564.c +0 -1
diff -Nur --exclude-from=dontdiff-osdl linux-2.6.11.6-clean/drivers/i2c/chips/rtc8564.c linux-2.6.11.6/drivers/i2c/chips/rtc8564.c
@@ -19,7 +19,6 @@
 #include <linux/string.h>
 #include <linux/rtc.h>		/* get the user-level API */
 #include <linux/init.h>
-#include <linux/init.h>
 
 #include "rtc8564.h"
 
#1 lore raw

Hi Clemens,

Quoted 10 lines

[PATCH] I2C rtc8564.c remove duplicate include

Trivial fix: removes duplicate include line.

Patch applies to: 2.6.11.x

(This is my very first patch to the linux-kernel, so let me start with small things first...)

There's nothing wrong with small things like that, but unfortunately your patch is somehow malformed and won't apply. Maybe your e-mail client broke it. Still I am interested in this clean up patch, so I would appreciate if you could check what went wrong, fix it and send a working patch.

Thanks,

Signature · 1 line
Jean Delvare
#2 lore raw

Re: [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed)

[PATCH] I2C rtc8564.c remove duplicate include

Trivial fix: removes duplicate include line.
Patch applies to: 2.6.11.x

(This is my very first patch to the linux-kernel, so let me start with small things first...)

---

drivers/i2c/chips/rtc8564.c +0 -1
diff -Nur --exclude-from=dontdiff-osdl linux-2.6.11.6-clean/drivers/i2c/chips/rtc8564.c linux-2.6.11.6/drivers/i2c/chips/rtc8564.c
@@ -19,7 +19,6 @@
 #include <linux/string.h>
 #include <linux/rtc.h>		/* get the user-level API */
 #include <linux/init.h>
-#include <linux/init.h>
 
 #include "rtc8564.h"
 
#3 lore raw

Re: [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed)

Hi Clemens,

Quoted 9 lines

[PATCH] I2C rtc8564.c remove duplicate include

Trivial fix: removes duplicate include line.
Patch applies to: 2.6.11.x

(This is my very first patch to the linux-kernel, so let me start with small things first...)

Thanks for the patch, I added it to my stack. Greg, please pick it for your i2c tree.

Signature · 1 line
Jean Delvare
Applied
#4 lore raw

Re: [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed)

In reply to Clemens Koller
Quoted 9 lines · Clemens Koller

[PATCH] I2C rtc8564.c remove duplicate include

Trivial fix: removes duplicate include line.
Patch applies to: 2.6.11.x

(This is my very first patch to the linux-kernel, so let me start with small things first...)

Applied, thanks.

greg k-h