soc: sunxi: Use of_property_present() for testing DT property presence
PATCH 1/1 soc: sunxi: Use of_property_present() for testing DT property presence
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more.
--- drivers/soc/sunxi/sunxi_mbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/sunxi/sunxi_mbus.c +1 -1
@@ -82,7 +82,7 @@ static int sunxi_mbus_notifier(struct notifier_block *nb,* Older DTs or SoCs who are not clearly understood need to set * that DMA offset though. */ -if (of_find_property (dev->of_node,"interconnects" ,NULL )) +if (of_property_present (dev->of_node,"interconnects" ))return NOTIFY_DONE ; ret =dma_direct_set_offset (dev,PHYS_OFFSET ,0 ,SZ_4G );
Signature · 1 line
2.39.2
Quoted 8 lines · On Fri, 10 Mar 2023 08:47:24 -0600 Rob Herring <[email protected]> wrote:
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added
of_property_present()helper when we just want to test for presence of a property and nothing more.Signed-off-by Rob Herring <[email protected]>
Cheers,
Andre
Quoted 17 lines
--- drivers/soc/sunxi/sunxi_mbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/soc/sunxi/sunxi_mbus.c +1
-1@@ -82,7 +82,7 @@ static int sunxi_mbus_notifier(struct notifier_block *nb,* Older DTs or SoCs who are not clearly understood need to set * that DMA offset though. */ -if (of_find_property (dev->of_node,"interconnects" ,NULL )) +if (of_property_present (dev->of_node,"interconnects" ))return NOTIFY_DONE ; ret =dma_direct_set_offset (dev,PHYS_OFFSET ,0 ,SZ_4G );
Dne petek, 10. marec 2023 ob 15:47:24 CET je Rob Herring napisal(a):
Quoted 7 lines
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added
of_property_present()helper when we just want to test for presence of a property and nothing more.
Quoted 5 lines
Signed-off-by Rob Herring <[email protected]>--- drivers/soc/sunxi/sunxi_mbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Best regards,
Jernej
Quoted 13 lines
drivers/soc/sunxi/sunxi_mbus.c +1
-1@@ -82,7 +82,7 @@ static int sunxi_mbus_notifier(struct notifier_block *nb,* Older DTs or SoCs who are not clearly understood need to set * that DMA offset though. */ -if (of_find_property (dev->of_node,"interconnects" ,NULL )) +if (of_property_present (dev->of_node,"interconnects" ))return NOTIFY_DONE ; ret =dma_direct_set_offset (dev,PHYS_OFFSET ,0 ,SZ_4G );
Dne petek, 10. marec 2023 ob 15:47:24 CET je Rob Herring napisal(a):
Quoted 8 lines
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added
of_property_present()helper when we just want to test for presence of a property and nothing more.Signed-off-by Rob Herring <[email protected]>
Applied, thanks!
Best regards,
Jernej