SLEEP_ON_BKLCHECK
Hi,
In Fedora Core3, interruptible_sleep_on() checks if the system is lock_kernel()'ed
by SLEEP_ON_BKLCHECK. Same thing is done in RedHatEL4.
Also I found a patch including SLEEP_ON_BKLCHECK was posted before, but is not included in 2.6.11.
Why SLEEP_ON_BKLCHECK checks lock_kernel ? Lock_kernel shoud be held during sleep_on_timeout? And I also wonder why 2.6.11 does not check it.
Thank you,
Please CC me because I am not subscribing this list. Yoshi Tsuchiya
Quoted 7 lines · tsuchiya yoshihiro
Hi,
In Fedora Core3,interruptible_sleep_on()checks if the system is lock_kernel()'ed
bySLEEP_ON_BKLCHECK. Same thing is done in RedHatEL4. Also I found a patch includingSLEEP_ON_BKLCHECKwas posted before, but is not included in 2.6.11.
WhySLEEP_ON_BKLCHECKcheckslock_kernel?
Because you really need to hold the BKL when you call sleep_on() family of APIs, otherwise you have a very big race.
Also note that you in your code really should not call any of the sleep_on() family of functions at all! It is a very very deprecated and defective API!!!!
Can you give the URL to the code where you use this in? (it is GPL code, right?)
Greetings,
Arjan van de Ven
Quoted 13 lines · Arjan van de Ven
Quoted 9 lines · tsuchiya yoshihiro
Hi,
In Fedora Core3,interruptible_sleep_on()checks if the system is lock_kernel()'ed
bySLEEP_ON_BKLCHECK. Same thing is done in RedHatEL4. Also I found a patch includingSLEEP_ON_BKLCHECKwas posted before, but is not included in 2.6.11.
WhySLEEP_ON_BKLCHECKcheckslock_kernel?
Quoted 9 lines
Because you really need to hold the BKL when you call
sleep_on()family of APIs, otherwise you have a very big race.Also note that you in your code really should not call any of the
sleep_on()family of functions at all! It is a very very deprecated and defective API!!!!
Oh, I did not know that.
What do you use instead? I found wait_event. Is that what you use?
Actually, I am porting my friend's code that runs on 2.4.X to 2.6. How is sleep_on in 2.4? You should not use sleep_on in 2.4 also?
Thank you,
Yoshi Tsuchiya
Quoted 18 lines · tsuchiya yoshihiro
Quoted 16 lines · Arjan van de Ven
Quoted 9 lines · tsuchiya yoshihiro
Hi,
In Fedora Core3,interruptible_sleep_on()checks if the system is lock_kernel()'ed
bySLEEP_ON_BKLCHECK. Same thing is done in RedHatEL4. Also I found a patch includingSLEEP_ON_BKLCHECKwas posted before, but is not included in 2.6.11.
WhySLEEP_ON_BKLCHECKcheckslock_kernel?Because you really need to hold the BKL when you call
sleep_on()family of APIs, otherwise you have a very big race.
Quoted 8 lines
Quoted 6 lines
Also note that you in your code really should not call any of the
sleep_on()family of functions at all! It is a very very deprecated and defective API!!!!Oh, I did not know that.
What do you use instead? I foundwait_event. Is that what you use?
yep
Quoted 3 lines
Actually, I am porting my friend's code that runs on 2.4.X to 2.6. How is
sleep_onin 2.4? You should not usesleep_onin 2.4 also?
correct, sleep_on in 2.4 is also broken and racey