Skip to contentSkip to conversation

Address Parsing

DISCUSSION Henne Vogelsang 4 participants 8 messages Mar 20, 2007 – Mar 21, 2007

lore
Share & tools
lore
#0 lore raw

Hi,

i had a listmember that sent a mail that included brackets in the address field. Something like that:

To: [email protected]
Cc: Heino Vogel <[email protected]>, [email protected], "Henne (Work)" <[email protected]>

After some testing we found that the to/cc parsing goes wrong here (maybe because () are illegal?). The 3. and 4. address never reach mlmmj and thus it thinks that the listaddress ([email protected]) is not in to or cc.

Henne

Signature · 2 lines
Henne Vogelsang, Teamlead Core Services
http://www.opensuse.org
#1 lore raw
Quoted 5 lines · Henne Vogelsang

Hi,

i had a listmember that sent a mail that included brackets in the address field. Something like that:

Quoted 8 lines

To: [email protected]
Cc: Heino Vogel <[email protected]>, [email protected], "Henne (Work)" <[email protected]>

After some testing we found that the to/cc parsing goes wrong here (maybe because () are illegal?). The 3. and 4. address never reach mlmmj and thus it thinks that the listaddress ([email protected]) is not in to or cc.

I just looked through find_email_address.c, and it's the same in FreeBSD-6.2, so the error must be ours?

Neal, it's been a while, am I remembering incorrectly that you added this code (which was a HUGE improvement still)?

Signature · 4 lines
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                 -- A. P. J.
#2 lore raw
In reply to Henne Vogelsang

Hi Henne,

Quoted 11 lines · Henne Vogelsang

i had a listmember that sent a mail that included brackets in the address field. Something like that:

To: [email protected]
Cc: Heino Vogel <[email protected]>, [email protected], "Henne (Work)" <[email protected]>

After some testing we found that the to/cc parsing goes wrong here (maybe because () are illegal?). The 3. and 4. address never reach mlmmj and thus it thinks that the listaddress ([email protected]) is not in to or cc.

The parsing failed at the quotes. The code looked for end-quote, and if the end-quote was after the comma, the comma was ignored. This should (obviously) only be done, if the begin-quote was before the comma.

This patch fixes the issue:
http://mlmmj.mmj.dk/~mortenp/patch-mlmmj-1.2.13-find_email_adr.diff

Neale, will you send this fix upstream to wherever-the-code-came-from? :-)

Morten

Signature · 2 lines
Morten K. Poulsen <[email protected]>
http://www.afdelingp.dk/
#3 lore raw
In reply to Henne Vogelsang
Quoted 4 lines · Morten K. Poulsen

This patch fixes the issue:
http://mlmmj.mmj.dk/~mortenp/patch-mlmmj-1.2.13-find_email_adr.diff

Neale, will you send this fix upstream to wherever-the-code-came-from? :-)

Morten you can log into panther and look in /usr/src/usr.bin/mail/aux.c :-))

FreeBSD 6.2 might have this bug as well.

Signature · 4 lines
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                 -- A. P. J.
#4 lore raw
In reply to Henne Vogelsang
Quoted 8 lines · Mads Martin Joergensen
Quoted 5 lines · Morten K. Poulsen

This patch fixes the issue:
http://mlmmj.mmj.dk/~mortenp/patch-mlmmj-1.2.13-find_email_adr.diff

Neale, will you send this fix upstream to wherever-the-code-came-from? :-)

Morten you can log into panther and look in /usr/src/usr.bin/mail/aux.c

I must have unsubscribed.

You guys are awesome, you found a bug with BSD mail? Way to go!

I have no idea whom to tell about it. I just grabbed that code off of some FreeBSD ports wotzit on the web.

#5 lore raw
In reply to Henne Vogelsang
Quoted 7 lines · Neale Pickett
Quoted 7 lines · Morten K. Poulsen
Quoted 5 lines

This patch fixes the issue:
http://mlmmj.mmj.dk/~mortenp/patch-mlmmj-1.2.13-find_email_adr.diff

Neale, will you send this fix upstream to wherever-the-code-came-from? :-)

Quoted 8 lines
Quoted 1 line

Morten you can log into panther and look in /usr/src/usr.bin/mail/aux.c

I must have unsubscribed.

You guys are awesome, you found a bug with BSD mail? Way to go!

I have no idea whom to tell about it. I just grabbed that code off of some FreeBSD ports wotzit on the web.

Someone needs to fire off send-pr(1) on a current FreeBSD machine. Panther is such, but since you, Morten, have found and fixed a bug in FreeBSD mail as Neale points out, you might want to send it yourself to get proper credit :-)

Just type send-pr, and you should be good to go.

Signature · 4 lines
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                 -- A. P. J.
#6 lore raw
In reply to Henne Vogelsang

Hi,

Quoted 8 lines · Morten K.Poulsen
Quoted 2 lines · Henne Vogelsang

i had a listmember that sent a mail that included brackets in the address field.

The parsing failed at the quotes.

This patch fixes the issue:
http://mlmmj.mmj.dk/~mortenp/patch-mlmmj-1.2.13-find_email_adr.diff

Verified. Running on lists.opensuse.org. Thanks for fixing :)

Henne

Signature · 2 lines
Henne Vogelsang, Teamlead Core Services
http://www.opensuse.org
#7 lore raw
In reply to Henne Vogelsang

Hi,

Quoted 3 lines · Mads Martin Joergensen
Quoted 2 lines · Neale Pickett
Quoted 2 lines

Morten you can log into panther and look in
/usr/src/usr.bin/mail/aux.c

[snip]

Quoted 1 line
Quoted 1 line

You guys are awesome, you found a bug with BSD mail? Way to go!

We may be awsome ;-) But the bug I fixed is not in BSD mail. It is only in mlmmj. It was added as a part of a fix for mlmmj-1.2.10:

o Fix nasty bug in the new 1.2.9 find_email_adr() making comma in quoted text in From: being discarded as invalid

Quoted 3 lines

... since you, Morten, have found and fixed a bug in FreeBSD mail as Neale points out, you might want to send it yourself to get proper credit :-)

Well, no FreeBSD credit for me in this round ;-)

But the bug is out of mlmmj. That's the main issue.

Morten

Signature · 2 lines
Morten K. Poulsen <[email protected]>
http://www.afdelingp.dk/