Potential null pointer dereference in serial driver (2.4) and amiga serial driver (2.6)
This is an example of a pointer which is dereferenced (two times), before beeing null checked.
Patches are attached.
Signed-off-by Julien TINNES <[email protected]>
drivers/char/serial.c +14 -4
@@ -1827,13 +1827,18 @@static void rs_put_char (struct tty_struct *tty,unsigned char ch) { -struct async_struct *info = (struct async_struct *)tty->driver_data; +struct async_struct *info;unsigned long flags; +if (!tty) +return ; + + info = (struct async_struct *)tty->driver_data; +if (serial_paranoia_check (info, tty->device,"rs_put_char" ))return ; -if (!tty || !info->xmit.buf) +if (!info->xmit.buf)return ;save_flags (flags);cli ();
@@ -1873,13 +1878,18 @@ const unsigned char *buf, int count) { int c, ret = 0; -struct async_struct *info = (struct async_struct *)tty->driver_data; +struct async_struct *info;unsigned long flags; +if (!tty) +return 0 ; + + info = (struct async_struct *)tty->driver_data; +if (serial_paranoia_check (info, tty->device,"rs_write" ))return 0 ; -if (!tty || !info->xmit.buf || !tmp_buf) +if (!info->xmit.buf || !tmp_buf)return 0 ;save_flags (flags);
drivers/char/amiserial.c +14 -4
@@ -861,13 +861,18 @@static void rs_put_char (struct tty_struct *tty,unsigned char ch) { -struct async_struct *info = (struct async_struct *)tty->driver_data; +struct async_struct *info;unsigned long flags; +if (!tty) +return ; + + info = (struct async_struct *)tty->driver_data; +if (serial_paranoia_check (info, tty->name,"rs_put_char" ))return ; -if (!tty || !info->xmit.buf) +if (!info->xmit.buf)return ;local_irq_save (flags);
@@ -910,13 +915,18 @@static int rs_write (struct tty_struct * tty,const unsigned char *buf,int count) {int c, ret =0 ; -struct async_struct *info = (struct async_struct *)tty->driver_data; +struct async_struct *info;unsigned long flags; +if (!tty) +return 0 ; + + info = (struct async_struct *)tty->driver_data; +if (serial_paranoia_check (info, tty->name,"rs_write" ))return 0 ; -if (!tty || !info->xmit.buf || !tmp_buf) +if (!info->xmit.buf || !tmp_buf)return 0 ;local_save_flags (flags);