Skip to contentSkip to conversation

skb_copy_bits() can return err

PATCH New Nivedita Singhvi 1 participant 1 message Jun 1, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 skb_copy_bits() can return err

skb_copy_bits() can return an err, so have netif_be_start_xmit() crash informatively..

thanks,
Nivedita

linux-2.6.11-xen-sparse/drivers/xen/netback/netback.c +3 -1
diff -urN xen-unstable-0601/linux-2.6.11-xen-sparse/drivers/xen/netback/netback.c niv-unstable-0601/linux-2.6.11-xen-sparse/drivers/xen/netback/netback.c
@@ -153,7 +153,9 @@
             goto drop;
         skb_reserve(nskb, hlen);
         __skb_put(nskb, skb->len);
-        (void)skb_copy_bits(skb, -hlen, nskb->data - hlen, skb->len + hlen);
+        if (skb_copy_bits(skb, -hlen, nskb->data - hlen, skb->len + hlen)) {
+		BUG();
+	}
         nskb->dev = skb->dev;
         nskb->proto_csum_valid = skb->proto_csum_valid;
         dev_kfree_skb(skb);

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel