include top config.mk only after CROSS_COMPILE is defined
PATCH 1/1 include top config.mk only after CROSS_COMPILE is defined
Hi Wolfgang!
During compiling I just spotted the fact that
gccincdir := $(shell $(CC) -print-file-name=include)
in the top config.mk does execute "gcc -print-file-name=include" instead of "m68k-elf-gcc ..." which I would expect as i compile for m68k. I think that this does not make much difference as the includes should mostly be the same, but for the sake of completeness I want to bring the attached patch to your attention.
Description of the patch:
* CROSS_COMPILE is referenced in the top 'config.mk' file therefore we need to include it in the main Makefile only after CROSS_COMPILE is defined
This patch is against the u-boot-1.1.2.
Signature · 6 lines
MfG / Regards Friedrich Lobenstock -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: u-boot-Makefile-patch Url: http://lists.denx.de/pipermail/u-boot/attachments/20050602/3ad0feba/attachment.txt
PATCH 1/1 include top config.mk only after CROSS_COMPILE is defined
Friedrich Lobenstock wrote on 02.06.2005 01:17 MET:
Quoted 8 lines
Description of the patch:
*
CROSS_COMPILEis referenced in the top 'config.mk' file therefore we need to include it in the mainMakefileonly afterCROSS_COMPILEis definedThis patch is against the u-boot-1.1.2.
Just checked, patch also applies cleanly to u-boot cvs head.
Signature · 2 lines
MfG / Regards Friedrich Lobenstock
PATCH 1/1 include top config.mk only after CROSS_COMPILE is defined
In reply to Friedrich LobenstockQuoted 9 lines · Friedrich Lobenstock
Hi Wolfgang!
During compiling I just spotted the fact that
gccincdir := $(shell $(CC) -print-file-name=include)
in the top config.mk does execute "gcc -print-file-name=include" instead of "m68k-elf-gcc ..." which I would expect as i compile for m68k. I think that this does not make much difference as the includes should mostly be the same, but for the sake of completeness I want to bring the attached patch to your attention.
Bump & resubmit...
This particular issue broke cross-compilation for all of our ARM-based projects following a repository sync yesterday.
The attached patch was generated against a 2005.11.29 CVS pull.
CHANGELOG:
* Patch by Cory Tusar, 30 Nov 2005:
* Original patch by Friedrich Lobenstock, 01 Jun 2005:
CROSS_COMPILE is referenced in the top 'config.mk' file, therefore we need to include it in the main Makefile only after CROSS_COMPILE has been defined.
-Cory
Signature · 21 lines
Cory T. Tusar
Embedded Systems Engineer
Videon Central, Inc.
2171 Sandy Drive
State College, PA 16801
(814) 235-1111 x316
(814) 235-1118 fax
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." --Brian W. Kernighan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: config.mk_depends_on_CROSS_COMPILE.patch
Type: text/x-patch
Size: 694 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20051130/1c45ea6b/attachment.bin Wolfgang Denk
AppliedPATCH 1/1 include top config.mk only after CROSS_COMPILE is defined
In reply to Friedrich LobenstockQuoted 4 lines · In message <[email protected]> you wrote:
*
CROSS_COMPILEis referenced in the top 'config.mk' file therefore we need to include it in the mainMakefileonly afterCROSS_COMPILEis defined
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Dear Lord: I just want *one* one-armed manager so I never have to hear "On the other hand", again.