Skip to contentSkip to conversation

sis5513.c patch take 2

PATCH Andrew Hutchings 2 participants 3 messages Jun 9, 2005

lore
Share & tools
lore
#0 lore raw

Hi,

Is this patch safer? I am burn-in testing it now and it seems work fine with UDMA transfers. I added the PCI ID of the northbridge as suggested.

Regards
Andrew

Signature · 4 lines
Andrew Hutchings (A-Wing)
Linux Guru - Netserve Consultants Ltd. - http://www.domaincity.co.uk/
Admin - North Wales Linux User Group - http://www.nwlug.org.uk/
BOFH excuse 348: We're on Token Ring, and it looks like the token got loose.
drivers/ide/pci/sis5513.c +1 -0
@@ -87,6 +87,7 @@
 	u8 chipset_family;
 	u8 flags;
 } SiSHostChipInfo[] = {
+	{ "SiS760",	PCI_DEVICE_ID_SI_760,	ATA_133	 },
 	{ "SiS745",	PCI_DEVICE_ID_SI_745,	ATA_100  },
 	{ "SiS735",	PCI_DEVICE_ID_SI_735,	ATA_100  },
 	{ "SiS733",	PCI_DEVICE_ID_SI_733,	ATA_100  },
#1 lore raw

Hi,

Quoted 4 lines · Andrew Hutchings

Hi,

Is this patch safer? I am burn-in testing it now and it seems work fine with UDMA transfers. I added the PCI ID of the northbridge as suggested.

Thanks, could you also try this simple debugging patch? [ without applying your patch ]

It may be possible to add generic 965L support just like 962/936L one (also NorthBridge<->SouthBridge mapping is not unique nowadays).

Bartlomiej

drivers/ide/pci/sis5513.c +2 -0
@@ -765,6 +765,8 @@
 			pci_read_config_word(dev, PCI_DEVICE_ID, &trueid);
 			pci_write_config_dword(dev, 0x54, idemisc);
 
+			printk(KERN_INFO "SIS5513: trueid=0x%x\n", trueid);
+
 			if (trueid == 0x5518) {
 				printk(KERN_INFO "SIS5513: SiS 962/963 MuTIOL IDE UDMA133 controller\n");
 				chipset_family = ATA_133;
#2 lore raw
Quoted 4 lines · Bartlomiej Zolnierkiewicz

Hi,

On 6/9/05, Andrew Hutchings <[email protected]> wrote:

Quoted 8 lines
Quoted 4 lines

Hi,

Is this patch safer? I am burn-in testing it now and it seems work fine with UDMA transfers. I added the PCI ID of the northbridge as suggested.

Thanks, could you also try this simple debugging patch? [ without applying your patch ]

Not a problem, just compiled it, the result is trueid=0x180

Quoted 2 lines

It may be possible to add generic 965L support just like 962/936L one (also NorthBridge<->SouthBridge mapping is not unique nowadays).

I was thinking that you said to use the NorthBridge

Regards
Andrew

Signature · 4 lines
Andrew Hutchings (A-Wing)
Linux Guru - Netserve Consultants Ltd. - http://www.domaincity.co.uk/
Admin - North Wales Linux User Group - http://www.nwlug.org.uk/
BOFH excuse 178: short leg on process table