Skip to contentSkip to conversation

cg-Xlib: make showdate show timezone

PATCH Applied Dan Holmsand 2 participants 3 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cg-Xlib: make showdate show timezone

This makes timezones show up again in showdate's default format. Hopefully, this also makes showdate a little more portable.

It also speeds things up a little, by avoiding an extra fork.

---

 cg-Xlib |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
cg-Xlib +3 -5
@@ -68,14 +68,12 @@ showdate () {
 	# bash doesn't like leading zeros
 	[ "${tzhours:1:1}" = 0 ] && tzhours=${2:0:1}${2:2:1}
 	secs=$(($secs + $tzhours * 3600 + $tzmins * 60))
+	[ "$format" ] || format="+%a, %d %b %Y %H:%M:%S $2"
 	if [ "$has_gnudate" ]; then
-		[ "$format" ] || format=-R
-		pdate=$(date -ud "1970-01-01 UTC + $secs sec" "$format")
+		LANG=C date -ud "1970-01-01 UTC + $secs sec" "$format"
 	else
-		[ "$format" ] || format=--
-		pdate=$(date -u -r $secs "$format")
+		LANG=C date -u -r $secs "$format"
 	fi
-	echo "${pdate/+0000/$tz}"
 }
 
 # Usage: tree_timewarp [--no-head-update] DIRECTION_STR ROLLBACK_BOOL BASE BRANCH
Applied
#1 lore raw

Dear diary, on Sun, Jun 12, 2005 at 01:40:57PM CEST, I got a letter where Dan Holmsand <[email protected]> told me that...

Quoted 7 lines

This makes timezones show up again in showdate's default format. Hopefully, this also makes showdate a little more portable.

It also speeds things up a little, by avoiding an extra fork.

Thanks, applied. But what's the point of calling date with LANG=C? If the user wants his locale to get used, why prevent him?

Signature · 3 lines
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
<Espy> be careful, some twit might quote you out of context..
#2 lore raw
Quoted 2 lines · Petr Baudis

Thanks, applied. But what's the point of calling date with LANG=C? If the user wants his locale to get used, why prevent him?

Because otherwise, you won't get an RFC-2822 date (which is what you explicitly wanted a couple of days ago, and what we had before).

Also, it would look pretty awkward to have parts of the output localized
(the date string), and all other parts not ("author", "date", whatnot).

/dan