Skip to contentSkip to conversation

3c59x: remove superfluous vortex_debug test from boomerang_start_xmit

PATCH In review John W. Linville 2 participants 3 messages Jun 10, 2005 – Jun 13, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 3c59x: remove superfluous vortex_debug test from boomerang_start_xmit

Remove the superfluous test of "if (vortex_debug > 3)" inside the "if (vortex_debug > 6)" clause early in boomerang_start_xmit.

---
I stumbled across this while looking at something else...

 drivers/net/3c59x.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
drivers/net/3c59x.c +2 -3
@@ -2202,9 +2202,8 @@ boomerang_start_xmit(struct sk_buff *skb
 
 	if (vortex_debug > 6) {
 		printk(KERN_DEBUG "boomerang_start_xmit()\n");
-		if (vortex_debug > 3)
-			printk(KERN_DEBUG "%s: Trying to send a packet, Tx index %d.\n",
-				   dev->name, vp->cur_tx);
+		printk(KERN_DEBUG "%s: Trying to send a packet, Tx index %d.\n",
+			   dev->name, vp->cur_tx);
 	}
 
 	if (vp->cur_tx - vp->dirty_tx >= TX_RING_SIZE) {
Signature · 2 lines
John W. Linville
[email protected]
#1 lore raw
Quoted 4 lines · John W. Linville

Remove the superfluous test of "if (vortex_debug > 3)" inside the "if (vortex_debug > 6)" clause early in boomerang_start_xmit.

ACK (I presume akpm will send this one upstream)