Skip to contentSkip to conversation

fix silly config option.

PATCH Dave Jones 3 participants 6 messages Jun 27, 2005 Media (V4L/DVB)

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the author meant to create.

drivers/media/video/Kconfig renamed from drivers/media/video/Kconfig~ +1 -1
@@ -7,7 +7,7 @@ menu "Video For Linux"
 
 comment "Video Adapters"
 
-config CONFIG_TUNER_MULTI_I2C
+config TUNER_MULTI_I2C
 	bool "Enable support for multiple I2C devices on Video Adapters (EXPERIMENTAL)"
 	depends on VIDEO_DEV && EXPERIMENTAL
 	---help---
#1 lore raw
Quoted 3 lines · Dave Jones

CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the author meant to create.
...

I can't find this option.

Which kernel is this patch against?

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#2 lore raw
Quoted 9 lines · Adrian Bunk
Quoted 3 lines · Dave Jones

CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the author meant to create.
...

I can't find this option.

Which kernel is this patch against?

2.6.12-git8 (git9 also needs it)

Dave

#3 lore raw
In reply to Dave Jones
Quoted 13 lines · Dave Jones

CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the author meant to create.

drivers/media/video/Kconfig renamed from drivers/media/video/Kconfig~ +0 -0
@@ -7,7 +7,7 @@ menu "Video For Linux"
 

comment "Video Adapters"

drivers/media/video/Kconfig renamed from drivers/media/video/Kconfig~ +1 -1
-config CONFIG_TUNER_MULTI_I2C
+config TUNER_MULTI_I2C
Quoted 5 lines
	bool "Enable support for multiple I2C devices on Video Adapters (EXPERIMENTAL)"
	depends on VIDEO_DEV && EXPERIMENTAL
	---help---

Dave-

If you do:

grep TUNER_MULTI_I2C < patch-2.6.12-git9

you will get:

+config CONFIG_TUNER_MULTI_I2C
+#define CONFIG_TUNER_MULTI_I2C /**/
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifndef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C

... So in fact, after applying your patch above, NOW it is a silly config option, which in effect, removed all functionality of CONFIG_TUNER_MULTI_I2C alltogether. It so happens that this has been completely removed in the current -mm, and I've confirmed with Mauro Chehab (video4linux maintainer) that nothing will be broken after applying your patch, so there is nothing to worry about. After the current tuner patches in -mm get merged, this whole thing will be a moot point.

Signature · 1 line
Michael Krufky
author
#4 lore raw
Quoted 11 lines · Michael Krufky
(quoted diff) +7 -0
+config CONFIG_TUNER_MULTI_I2C
+#define CONFIG_TUNER_MULTI_I2C /**/
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifndef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C

... So in fact, after applying your patch above, NOW it is a silly config option, which in effect, removed all functionality of CONFIG_TUNER_MULTI_I2C alltogether

Err, no. Note how no other config options have CONFIG_ prepended to them. Kconfig magic does this for you implicitly.

Dave

#5 lore raw
Quoted 10 lines · Dave Jones
Quoted 8 lines · Michael Krufky
(quoted diff) +7 -0
+config CONFIG_TUNER_MULTI_I2C
+#define CONFIG_TUNER_MULTI_I2C /**/
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifndef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
Quoted 5 lines
Quoted 1 line

... So in fact, after applying your patch above, NOW it is a silly config option, which in effect, removed all functionality of CONFIG_TUNER_MULTI_I2C alltogether

Err, no. Note how no other config options have CONFIG_ prepended to them. Kconfig magic does this for you implicitly.

OOPS! I stand corrected. :-)

Signature · 1 line
Michael Krufky