Skip to contentSkip to conversation

Silence GCC4 warning: pointer targets in

PATCH RESEND New Jesse Millan 1 participant 1 message Jun 29, 2005 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 Silence GCC4 warning: pointer targets in

GCC4 compares signedness of all pointer types. Assigning an unsigned pointer to a signed pointer (or vise-versa) generates a warning. In this case an unsigned char pointer was assigned the value of a signed char pointer. It looks like the author was aware of this so I just let it be. An explicit cast silences the warnings.
---

arch/x86_64/boot/compressed/misc.c renamed from arch/x86_64/boot/compressed/misc.c~misc-patch +3 -3
diff -puN arch/x86_64/boot/compressed/misc.c~misc-patch arch/x86_64/boot/compressed/misc.c
@@ -222,7 +222,7 @@ static int fill_inbuf(void)
 		error("ran out of input data");
 	}
 
-	inbuf = input_data;
+	inbuf = (uch *)input_data;
 	insize = input_len;
 	inptr = 1;
 	return inbuf[0];
@@ -288,7 +288,7 @@ void setup_normal_output_buffer(void)
 #else
 	if ((ALT_MEM_K > EXT_MEM_K ? ALT_MEM_K : EXT_MEM_K) < 1024) error("Less than 2MB of memory");
 #endif
-	output_data = (char *)__PHYSICAL_START; /* Normally Points to 1M */
+	output_data = (uch *)__PHYSICAL_START; /* Normally Points to 1M */
 	free_mem_end_ptr = (long)real_mode;
 }
 
@@ -305,7 +305,7 @@ void setup_output_buffer_if_we_run_high(
 #else
 	if ((ALT_MEM_K > EXT_MEM_K ? ALT_MEM_K : EXT_MEM_K) < (3*1024)) error("Less than 4MB of memory");
 #endif	
-	mv->low_buffer_start = output_data = (char *)LOW_BUFFER_START;
+	mv->low_buffer_start = output_data = (uch *)LOW_BUFFER_START;
 	low_buffer_end = ((unsigned int)real_mode > LOW_BUFFER_MAX
 	  ? LOW_BUFFER_MAX : (unsigned int)real_mode) & ~0xfff;
 	low_buffer_size = low_buffer_end - LOW_BUFFER_START;

_

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors