v4l cx88 hue offset fix
PATCH 1/1 v4l cx88 hue offset fix
Changed hue offset to 128 to correct behavior in cx88 cards. Previously, setting 0% or 100% hue was required to avoid blue/green people on screen. Now, 50% Hue means no offset, just like bt878 stuff.
cx88-video.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/media/video/cx88/cx88-video.c +1 -1
@@ -268,7 +268,7 @@ static struct cx88_ctrl cx8800_ctls[] = .default_value = 0, .type = V4L2_CTRL_TYPE_INTEGER, }, - .off = 0, + .off = 128, .reg = MO_HUE, .mask = 0x00ff, .shift = 0,
Quoted 11 lines · Michael Krufky
------------------------------------------------------------------------
Changed hue offset to 128 to correct behavior in cx88 cards. Previously, setting 0% or 100% hue was required to avoid blue/green people on screen. Now, 50% Hue means no offset, just like bt878 stuff.
Signed-off-by Michael Krufky <[email protected]>Signed-off-by Mauro Carvalho Chehab <[email protected]>
This small patch fixes top complain about CX88 cards, which had a
different behavior than other V4L cards for hue setting.
It can also be applied also at 2.6.13 mainstream.
PATCH 1/1 v4l cx88 hue offset fix
Quoted 7 lines · Mauro Carvalho Chehab
This small patch fixes top complaint about CX88 cards, which had a different behavior than other V4L cards for hue setting.
It can also be applied also at 2.6.13 mainstream.
I must add: Not only does this apply to 2.6.13, but it also applies to 2.6.12 ... Can we have this put into the patch queue for 2.6.12.3 ? This IS a bug fix, and makes a HUGE improvement for cx88 boards.
I'd really like to see this in the mainstream kernel before the livecd distros make their next releases.
I would send this to Greg Kroah-Hartman / Chris Wright myself, but I don't know if that is proper protocol for doing this. Andrew, please send this to the correct person.
Thank you.
Attached is a diff against 2.6.12.2
Signature · 1 line
Michael Krufky
Changed hue offset to 128 to correct behavior in cx88 cards. Previously, setting 0% or 100% hue was required to avoid blue/green people on screen. Now, 50% Hue means no offset, just like bt878 stuff.
cx88-video.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/media/video/cx88/cx88-video.c +1 -1
@@ -261,7 +261,7 @@ static struct cx88_ctrl cx8800_ctls[] = .default_value = 0, .type = V4L2_CTRL_TYPE_INTEGER, }, - .off = 0, + .off = 128, .reg = MO_HUE, .mask = 0x00ff, .shift = 0,
Quoted 7 lines · Michael Krufky
Quoted 5 lines · Mauro Carvalho Chehab
This small patch fixes top complaint about CX88 cards, which had a different behavior than other V4L cards for hue setting.
[...]
Quoted 3 lines
I would send this to Greg Kroah-Hartman / Chris Wright myself, but I don't know if that is proper protocol for doing this.
http://kerneltrap.org/mailarchive/1/message/33322/thread
See the "Procedure for submitting patches to the -stable tree" section in particular.
(that document really should go into Documentation/ by the way)
Signature · 3 lines
Jesper Juhl <[email protected]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html