Skip to contentSkip to conversation

Add commify function to cg-Xlib

PATCH In review Frank Sorenson 2 participants 4 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add commify function to cg-Xlib

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Here is a patch to add a commify function to cg-Xlib. I'll follow this up with a patch that uses the new function to commify the number and size of objects pulled in cg-pull.

Add a commify function to cg-Xlib

- ---
commit de4fd646c8307777137b9a4c1b5735f9573167f6
tree 1b9d3d0db498fde457d60f6658f616a1aa6b9fe3
parent b21855b8734ca76ea08c0c17e4a204191b6e3add
author Frank Sorenson <[email protected]> Wed, 06 Jul 2005 00:38:16 -0600 committer Frank Sorenson <[email protected]> Wed, 06 Jul 2005 00:38:16 -0600

 cg-Xlib |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
cg-Xlib +0 -0

- --- a/cg-Xlib
+++ b/cg-Xlib
@@ -128,6 +128,9 @@ update_index () {
git-update-cache --refresh | sed 's/needs update$/locally modified/'
}

+commify() {
+ echo $1 | sed ':a;s/\B[0-9]\{3\}\>/,&/;ta'
+}

print_help () {
which "cg-$1" >/dev/null 2>&1 || exit 1

Frank
- --
Frank Sorenson - KD7TZK
Systems Manager, Computer Science Department
Brigham Young University
[email protected]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCy4GiaI0dwg4A47wRAg+vAJ9ZCn7ptBARMY+ELyS+uQ893/aDLgCgsk8b dhfcgflxQRURowVFP2qiRe4=
=u7ap
-----END PGP SIGNATURE-----

#1 lore raw

Dear diary, on Wed, Jul 06, 2005 at 09:00:50AM CEST, I got a letter where Frank Sorenson <[email protected]> told me that...

Quoted 5 lines

Here is a patch to add a commify function to cg-Xlib. I'll follow this up with a patch that uses the new function to commify the number and size of objects pulled in cg-pull.

I don't know. Could you give some supporting argumentation, please? Is it really that hard to read for the Americans without the commas? It is at least harder to read for me as an European - we don't have any commas in there, just spaces (if anything at all). Besides, the number is usually not in higher order than thousands, so... why is it worth it?

Signature · 3 lines
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
<Espy> be careful, some twit might quote you out of context..
#2 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 5 lines · Petr Baudis

I don't know. Could you give some supporting argumentation, please? Is it really that hard to read for the Americans without the commas? It is at least harder to read for me as an European - we don't have any commas in there, just spaces (if anything at all). Besides, the number is usually not in higher order than thousands, so... why is it worth it?

Okay. Not a problem. It just cleaned things up a little for me. If I want to keep it, I'll probably just maintain it in my local tree.

Frank
- --
Frank Sorenson - KD7TZK
Systems Manager, Computer Science Department
Brigham Young University
[email protected]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCzBumaI0dwg4A47wRAmKKAJ90HJymEjSHwvpKq7pjQkXf9wz7sACfXl8F BttVqvdhovFaGYEn9PibeC0=
=N90S
-----END PGP SIGNATURE-----

#3 lore raw

PATCH 1/1 Commify numbers in cg-pull

In reply to Frank Sorenson

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Here is a patch to commify the number and size of objects pulled in cg-pull. Depends on the previous "Add commify function" patch.

Commify number and size of objects pulled in pull_progress

- ---
commit 03fb604eb8c24851096cca14bed19f4eacc79686
tree 191e8aa3a034e302aa660a9a5b5c0c64e2e88ac9
parent de4fd646c8307777137b9a4c1b5735f9573167f6
author Frank Sorenson <[email protected]> Wed, 06 Jul 2005 00:47:56 -0600 committer Frank Sorenson <[email protected]> Wed, 06 Jul 2005 00:47:56 -0600

 cg-pull |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
cg-pull +0 -0

- --- a/cg-pull
+++ b/cg-pull
@@ -82,7 +82,7 @@ pull_progress() {
size=$(($size + $(stat -c '%s' "$object" 2>/dev/null))) objects=$(($objects + 1));

- - echo -ne "progress: $objects objects, $size bytes$percentage\r"
+ echo -ne "progress: $(commify $objects) objects, $(commify $size) bytes$percentage\r"
done;
[ "$last_objects" != "$objects" ] && echo
}

Frank
- --
Frank Sorenson - KD7TZK
Systems Manager, Computer Science Department
Brigham Young University
[email protected]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCy4J4aI0dwg4A47wRAihxAKCOAioNWvYBDPkOvk/hYUgfUuMdewCgm1ea 4IGx09Ew6tytbOAyPrUxHZU=
=YM7f
-----END PGP SIGNATURE-----