Skip to contentSkip to conversation

reiserfs: reformat code with Lindent

PATCH In review Jeff Mahoney 3 participants 5 messages Jul 7, 2005

lore
Share & tools
lore

Jeff Mahoney

author
#0 lore raw

PATCH 1/1 reiserfs: reformat code with Lindent

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey all -

Just out of curiousity, does anyone outside of Chris and I have outstanding patches against ReiserFS? I ask because the tree has been relatively stable for some time and I wonder if it may be time to submit a Lindent patch to clean up the code and reformat it to adhere to the kernel style guidelines.

I've posted a patch[1] that is only the output of the Lindent script. Ideally, there should be some string formatting in there as well, but I'd like to split them up into separate pieces so we know each chunk is correct. Sorry I couldn't attach it - it was rejected by the list since it is over 128k in size.

Opinions?

- -Jeff
[1]:
ftp://ftp.suse.com/pub/people/jeffm/reiserfs/kernel-v2.6/cleanups/2.6.13-rc2/01-reiserfs-lindent.diff

- --
Jeff Mahoney
SuSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCzYzFLPWxlyuTD7IRAgrZAJ0YpbRkSz7XoGKOyal62s1qTGdw/wCcCNQx aFRMUp8q8+cRQ6XluvE5zgg=
=ZYGV
-----END PGP SIGNATURE-----

#1 lore raw
Quoted 16 lines · Jeff Mahoney

Hey all -

Just out of curiousity, does anyone outside of Chris and I have outstanding patches against ReiserFS? I ask because the tree has been relatively stable for some time and I wonder if it may be time to submit a Lindent patch to clean up the code and reformat it to adhere to the kernel style guidelines.

I've posted a patch[1] that is only the output of the Lindent script. Ideally, there should be some string formatting in there as well, but I'd like to split them up into separate pieces so we know each chunk is correct. Sorry I couldn't attach it - it was rejected by the list since it is over 128k in size.

Opinions?

Quoted 7 lines

-Jeff
[1]:
ftp://ftp.suse.com/pub/people/jeffm/reiserfs/kernel-v2.6/cleanups/2.6.13-rc2/01-reiserfs-lindent.diff

--
Jeff Mahoney
SuSE Labs

I don't have any enthusiasm or desire for changing the indentation, but I will not fight it to the death.

#2 lore raw
In reply to Jeff Mahoney

Hello

Quoted 4 lines · Jeff Mahoney

Hey all -

Just out of curiousity, does anyone outside of Chris and I have outstanding patches against ReiserFS?

I have no idea how the attached patch managed to not get included.

I ask because the tree has been

Quoted 12 lines

relatively stable for some time and I wonder if it may be time to submit a Lindent patch to clean up the code and reformat it to adhere to the kernel style guidelines.

I've posted a patch[1] that is only the output of the Lindent script. Ideally, there should be some string formatting in there as well, but I'd like to split them up into separate pieces so we know each chunk is correct. Sorry I couldn't attach it - it was rejected by the list since it is over 128k in size.

Opinions?

Quoted 7 lines

-Jeff
[1]:
ftp://ftp.suse.com/pub/people/jeffm/reiserfs/kernel-v2.6/cleanups/2.6.13-rc2/01-reiserfs-lindent.diff

--
Jeff Mahoney
SuSE Labs

 fs/reiserfs/super.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/reiserfs/super.c renamed from fs/reiserfs/super.c~reiserfs-old-read-bitmap +2 -2
diff -puN fs/reiserfs/super.c~reiserfs-old-read-bitmap fs/reiserfs/super.c
@@ -1286,11 +1286,11 @@ static int read_old_bitmaps (struct supe
   int bmp1 = (REISERFS_OLD_DISK_OFFSET_IN_BYTES / s->s_blocksize) + 1;  /* first of bitmap blocks */
 
   /* read true bitmap */
-  SB_AP_BITMAP (s) = vmalloc (sizeof (struct reiserfs_buffer_info *) * sb_bmap_nr(rs));
+  SB_AP_BITMAP (s) = vmalloc (sizeof (struct reiserfs_bitmap_info) * sb_bmap_nr(rs));
   if (SB_AP_BITMAP (s) == 0)
     return 1;
 
-  memset (SB_AP_BITMAP (s), 0, sizeof (struct reiserfs_buffer_info *) * sb_bmap_nr(rs));
+  memset (SB_AP_BITMAP (s), 0, sizeof (struct reiserfs_bitmap_info) * sb_bmap_nr(rs));
 
   for (i = 0; i < sb_bmap_nr(rs); i ++) {
     SB_AP_BITMAP (s)[i].bh = sb_bread (s, bmp1 + i);

_

author
#3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 9 lines · Vladimir V. Saveliev

Hello

Quoted 4 lines · Jeff Mahoney

Hey all -

Just out of curiousity, does anyone outside of Chris and I have outstanding patches against ReiserFS?

I have no idea how the attached patch managed to not get included.

Interesting. I guess that pretty much tells us how many people are using old format disks on somewhat recent kernels. :)

Have you resubmitted?

- -Jeff

- --
Jeff Mahoney
SuSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCzZogLPWxlyuTD7IRAteZAJsH/wsTSnsUrublVKUQny/rgadelACfd5iK hxltGLICaSwEX+rfxzAEkCM=
=sstn
-----END PGP SIGNATURE-----

#4 lore raw

Hello

Quoted 8 lines · Jeff Mahoney
Quoted 6 lines · Vladimir V. Saveliev
Quoted 6 lines

Hello

Quoted 2 lines · Jeff Mahoney

Hey all -

Quoted 9 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

Just out of curiousity, does anyone outside of Chris and I have outstanding patches against ReiserFS?

I have no idea how the attached patch managed to not get included.

Interesting. I guess that pretty much tells us how many people are using old format disks on somewhat recent kernels. :)

yes, but less then one month ago we had a bug report: user could not mount because of this problem.

Quoted 1 line

Have you resubmitted?

no

Quoted 6 lines

-Jeff

--
Jeff Mahoney
SuSE Labs