Skip to contentSkip to conversation

drivers/net/pcmcia/3c589_cs.c : Use of time_befor macro

PATCH New Marcelo Feitoza Parisi 1 participant 1 message Jul 8, 2005 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/net/pcmcia/3c589_cs.c : Use of time_befor macro

Use of time_before() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read.

--- linux/drivers/net/pcmcia/3c589_cs.c 2005-07-07 19:11:51.000000000 -0300
+++ linux-kj/drivers/net/pcmcia/3c589_cs.c 2005-07-07
22:59:40.020435184 -0300
@@ -39,6 +39,7 @@
#include <linux/if_arp.h>
#include <linux/ioport.h>
#include <linux/bitops.h>
+#include <linux/jiffies.h>

#include <pcmcia/version.h>
#include <pcmcia/cs_types.h>
@@ -850,7 +851,7 @@

     media = inw(ioaddr+WN4_MEDIA) & 0xc810;

     /* Ignore collisions unless we've had no irq's recently */
-    if (jiffies - lp->last_irq < HZ) {
+    if (time_before(jiffies, lp->last_irq + HZ)) {
        media &= ~0x0010;
     } else {
        /* Try harder to detect carrier errors */

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors