Skip to contentSkip to conversation

Add missing tvaudio try_to_freeze.

PATCH In review Nigel Cunningham 3 participants 4 messages Jul 18, 2005 – Jul 26, 2005 Media (V4L/DVB)

lore
Share & tools
lore

Nigel Cunningham

author
#0 lore raw

PATCH 1/1 Add missing tvaudio try_to_freeze.

Hi.

The .c gives Gerd Knorr as the maintainer of this file, but no email address. The MAINTAINERS file doesn't have his name or make it clear who owns the file. I haven't therefore been able to cc the maintainer.

Tvaudio lacks a refrigerator call. This patch fixes that.

Regards,

Nigel

Signed-off by: Nigel Cunningham <[email protected]>

 tvaudio.c |    1 +
 1 files changed, 1 insertion(+)
drivers/media/video/tvaudio.c +1 -0
diff -ruNp 234-tvaudio.patch-old/drivers/media/video/tvaudio.c 234-tvaudio.patch-new/drivers/media/video/tvaudio.c
@@ -285,6 +285,7 @@ static int chip_thread(void *data)
 			schedule();
 		}
 		remove_wait_queue(&chip->wq, &wait);
+		try_to_freeze();
 		if (chip->done || signal_pending(current))
 			break;
 		dprintk("%s: thread wakeup\n", i2c_clientname(&chip->c));
Signature · 5 lines
Evolution.
Enumerate the requirements.
Consider the interdependencies.
Calculate the probabilities.
Be amazed that people believe it happened.
#1 lore raw

Nigel,

Quoted 5 lines · Nigel Cunningham

Hi.

The .c gives Gerd Knorr as the maintainer of this file, but no email address. The MAINTAINERS file doesn't have his name or make it clear who owns the file. I haven't therefore been able to cc the maintainer.

I'm current maintainer of V4L. The patch was tested and it looks ok.

Quoted 8 lines

Tvaudio lacks a refrigerator call. This patch fixes that.

Regards,

Nigel

Signed-off by: Nigel Cunningham <[email protected]>

Signed-off-by Mauro Carvalho Chehab <[email protected]>
author
#2 lore raw

Hi.

Quoted 10 lines · Mauro Carvalho Chehab

Nigel,

Quoted 5 lines · Nigel Cunningham

Hi.

The .c gives Gerd Knorr as the maintainer of this file, but no email address. The MAINTAINERS file doesn't have his name or make it clear who owns the file. I haven't therefore been able to cc the maintainer.

I'm current maintainer of V4L. The patch was tested and it looks ok.

Thanks! Would you consider sending a patch to the maintainers file too?

Regards,

Nigel

Quoted 9 lines
Quoted 8 lines

Tvaudio lacks a refrigerator call. This patch fixes that.

Regards,

Nigel

Signed-off by: Nigel Cunningham <[email protected]>

Signed-off-by Mauro Carvalho Chehab <[email protected]>
Signature · 4 lines
Evolution.
Enumerate the requirements.
Consider the interdependencies.
Calculate the probabilities.
Acked-by Gerd Knorr
#3 lore raw
Quoted 11 lines · Nigel Cunningham
Quoted 8 lines · Mauro Carvalho Chehab
Quoted 5 lines · Nigel Cunningham

The .c gives Gerd Knorr as the maintainer of this file, but no email address. The MAINTAINERS file doesn't have his name or make it clear who owns the file. I haven't therefore been able to cc the maintainer.

Quoted 6 lines
Quoted 3 lines

I'm current maintainer of V4L. The patch was tested and it looks ok.

Thanks! Would you consider sending a patch to the maintainers file too?

As you can see below, this has already been done.

[PATCH] V4L maintainer patch
author Mauro Carvalho Chehab <[email protected]>
Wed, 29 Jun 2005 03:45:20 +0000 (20:45 -0700)
committer Linus Torvalds <[email protected]>
Wed, 29 Jun 2005 04:20:36 +0000 (21:20 -0700)
commit 96b6aba08762f09e5dfa616854cb80ce054a7bf8
tree 788823ba3676e17b5f376ec6718dcf60662eaf87 tree
parent 200803dfe4ff772740d63db725ab2f1b185ccf92 commit | commitdiff
[PATCH] V4L maintainer patch

This patch updates maintainer info for BTTV and V4L.

Signed-off-by Mauro Carvalho Chehab <[email protected]>
Acked-by Gerd Knorr <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
Signed-off-by Linus Torvalds <[email protected]>
Signature · 1 line
Michael Krufky