Skip to contentSkip to conversation

DVB: rename lgdt3302 frontend module to lgdt330x

PATCH In review Michael Krufky 5 participants 7 messages Jul 25, 2005 – Sep 9, 2005 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DVB: rename lgdt3302 frontend module to lgdt330x

This patch depends on the following patches to be applied first in order to apply cleanly:

01-lgdt3302-isolate-tuner.patch
02-lgdt3302-rf-input.patch
03-lgdt3302-suppress-compile-warning.patch
04-cx88-dvb-cleanup.patch
[-mm PATCH] v4l: hybrid dvb: fix warnings with -Wundef
[-mm PATCH] v4l: hybrid dvb: move #defines to Makefile
[-mm PATCH] v4l: hybrid dvb: rename CFLAGS from CONFIG_DVB_xxxx back to original HAVE_xxxx

I am listing these because I haven't seen any of these in -mm-commits mailing list yet. (No commits at all for a week or so....)

I am changing the name of this module now so that hopefully the name will be changed before the release of 2.6.13 ... It wouldn't make sense to release 2.6.13 with the name lgdt3302 in it, which will only be renamed to lgdt330x in later versions.

Andrew-

If you, for any reason, don't want to send my #ifdef changes to 2.6.13 right away, just let me know and I'll regenerate these patches such that the #ifdef patches aren't a prerequisite... Although it would just be a lot easier to merge all of the patches above...

Rename lgdt3302 to lgdt330x, to make way for the addition of lgdt3303 support in future revisions.

 linux/drivers/media/dvb/frontends/Kconfig         |    4 
 linux/drivers/media/dvb/frontends/Makefile        |    2 
 linux/drivers/media/dvb/frontends/lgdt3302.c      |  607 --------------
 linux/drivers/media/dvb/frontends/lgdt3302.h      |   49 -
 linux/drivers/media/dvb/frontends/lgdt3302_priv.h |   72 -
 linux/drivers/media/dvb/frontends/lgdt330x.c      |  606 +++++++++++++
 linux/drivers/media/dvb/frontends/lgdt330x.h      |   49 +
 linux/drivers/media/dvb/frontends/lgdt330x_priv.h |   70 +
 linux/drivers/media/video/Kconfig                 |    2 
 linux/drivers/media/video/cx88/Makefile           |    4 
 linux/drivers/media/video/cx88/cx88-dvb.c         |   29 
 linux/drivers/media/video/cx88/cx88-i2c.c         |    4 
 12 files changed, 747 insertions(+), 751 deletions(-)
drivers/media/video/cx88/cx88-dvb.c +14 -15
diff -u linux-2.6.13/drivers/media/video/cx88/cx88-dvb.c linux/drivers/media/video/cx88/cx88-dvb.c
@@ -1,5 +1,5 @@
 /*
- * $Id: cx88-dvb.c,v 1.52 2005/07/24 22:12:47 mkrufky Exp $
+ * $Id: cx88-dvb.c,v 1.54 2005/07/25 05:13:50 mkrufky Exp $
  *
  * device driver for Conexant 2388x based TV cards
  * MPEG Transport Stream (DVB) routines
@@ -31,7 +31,6 @@
 #include <linux/suspend.h>
 #include <linux/config.h>
 
-
 #include "cx88.h"
 #include "dvb-pll.h"
 
@@ -45,8 +44,8 @@
 #ifdef HAVE_OR51132
 # include "or51132.h"
 #endif
-#ifdef HAVE_LGDT3302
-# include "lgdt3302.h"
+#ifdef HAVE_LGDT330X
+# include "lgdt330x.h"
 #endif
 
 MODULE_DESCRIPTION("driver for cx2388x based DVB cards");
@@ -207,8 +206,8 @@
 };
 #endif
 
-#ifdef HAVE_LGDT3302
-static int lgdt3302_pll_set(struct dvb_frontend* fe,
+#ifdef HAVE_LGDT330X
+static int lgdt330x_pll_set(struct dvb_frontend* fe,
 			    struct dvb_frontend_parameters* params,
 			    u8* pllbuf)
 {
@@ -220,7 +219,7 @@
 	return 0;
 }
 
-static int lgdt3302_pll_rf_set(struct dvb_frontend* fe, int index)
+static int lgdt330x_pll_rf_set(struct dvb_frontend* fe, int index)
 {
 	struct cx8802_dev *dev= fe->dvb->priv;
 	struct cx88_core *core = dev->core;
@@ -233,7 +232,7 @@
 	return 0;
 }
 
-static int lgdt3302_set_ts_param(struct dvb_frontend* fe, int is_punctured)
+static int lgdt330x_set_ts_param(struct dvb_frontend* fe, int is_punctured)
 {
 	struct cx8802_dev *dev= fe->dvb->priv;
 	if (is_punctured)
@@ -243,10 +242,10 @@
 	return 0;
 }
 
-static struct lgdt3302_config fusionhdtv_3_gold = {
+static struct lgdt330x_config fusionhdtv_3_gold = {
 	.demod_address    = 0x0e,
-	.pll_set          = lgdt3302_pll_set,
-	.set_ts_params    = lgdt3302_set_ts_param,
+	.pll_set          = lgdt330x_pll_set,
+	.set_ts_params    = lgdt330x_set_ts_param,
 };
 #endif
 
@@ -297,7 +296,7 @@
 						 &dev->core->i2c_adap);
 		break;
 #endif
-#ifdef HAVE_LGDT3302
+#ifdef HAVE_LGDT330X
 	case CX88_BOARD_DVICO_FUSIONHDTV_3_GOLD_Q:
 		dev->ts_gen_cntrl = 0x08;
 		{
@@ -310,10 +309,10 @@
 		mdelay(200);
 
 		/* Select RF connector callback */
-		fusionhdtv_3_gold.pll_rf_set = lgdt3302_pll_rf_set;
+		fusionhdtv_3_gold.pll_rf_set = lgdt330x_pll_rf_set;
 		dev->core->pll_addr = 0x61;
 		dev->core->pll_desc = &dvb_pll_microtune_4042;
-		dev->dvb.frontend = lgdt3302_attach(&fusionhdtv_3_gold,
+		dev->dvb.frontend = lgdt330x_attach(&fusionhdtv_3_gold,
 						    &dev->core->i2c_adap);
 		}
 		break;
@@ -329,7 +328,7 @@
 		mdelay(200);
 		dev->core->pll_addr = 0x61;
 		dev->core->pll_desc = &dvb_pll_thomson_dtt7611;
-		dev->dvb.frontend = lgdt3302_attach(&fusionhdtv_3_gold,
+		dev->dvb.frontend = lgdt330x_attach(&fusionhdtv_3_gold,
 						    &dev->core->i2c_adap);
 		}
 		break;
drivers/media/video/cx88/cx88-i2c.c +2 -2
diff -u linux-2.6.13/drivers/media/video/cx88/cx88-i2c.c linux/drivers/media/video/cx88/cx88-i2c.c
@@ -1,5 +1,5 @@
 /*
-    $Id: cx88-i2c.c,v 1.28 2005/07/05 17:37:35 nsh Exp $
+    $Id: cx88-i2c.c,v 1.30 2005/07/25 05:10:13 mkrufky Exp $
 
     cx88-i2c.c  --  all the i2c code is here
 
@@ -164,7 +164,7 @@
 };
 
 static char *i2c_devs[128] = {
-	[ 0x1c >> 1 ] = "lgdt3302",
+	[ 0x1c >> 1 ] = "lgdt330x",
 	[ 0x86 >> 1 ] = "tda9887/cx22702",
 	[ 0xa0 >> 1 ] = "eeprom",
 	[ 0xc0 >> 1 ] = "tuner (analog)",
drivers/media/video/cx88/Makefile +2 -2
diff -u linux-2.6.13/drivers/media/video/cx88/Makefile linux/drivers/media/video/cx88/Makefile
@@ -15,8 +15,8 @@
 ifneq ($(CONFIG_DVB_OR51132),n)
  EXTRA_CFLAGS += -DHAVE_OR51132=1
 endif
-ifneq ($(CONFIG_DVB_LGDT3302),n)
- EXTRA_CFLAGS += -DHAVE_LGDT3302=1
+ifneq ($(CONFIG_DVB_LGDT330X),n)
+ EXTRA_CFLAGS += -DHAVE_LGDT330X=1
 endif
 ifneq ($(CONFIG_DVB_MT352),n)
  EXTRA_CFLAGS += -DHAVE_MT352=1
drivers/media/dvb/frontends/lgdt330x.c +606 -0

606 lines not on this page · raw message

drivers/media/dvb/frontends/lgdt330x.h +49 -0

49 lines not on this page · raw message

drivers/media/dvb/frontends/lgdt330x_priv.h +70 -0

70 lines not on this page · raw message

drivers/media/dvb/frontends/lgdt3302.c +0 -607

607 lines not on this page · raw message

drivers/media/dvb/frontends/lgdt3302.h +0 -49

49 lines not on this page · raw message

drivers/media/dvb/frontends/lgdt3302_priv.h +0 -72

72 lines not on this page · raw message

drivers/media/video/Kconfig +1 -1
diff -u linux-2.6.13/drivers/media/video/Kconfig linux/drivers/media/video/Kconfig
@@ -331,7 +331,7 @@
 	select DVB_MT352
 	select DVB_OR51132
 	select DVB_CX22702
-	select DVB_LGDT3302
+	select DVB_LGDT330X
 	---help---
 	  This adds support for DVB/ATSC cards based on the
 	  Connexant 2388x chip.
drivers/media/dvb/frontends/Makefile +1 -1
diff -u linux-2.6.13/drivers/media/dvb/frontends/Makefile linux/drivers/media/dvb/frontends/Makefile
@@ -30,4 +30,4 @@
 obj-$(CONFIG_DVB_OR51132) += or51132.o
 obj-$(CONFIG_DVB_BCM3510) += bcm3510.o
 obj-$(CONFIG_DVB_S5H1420) += s5h1420.o
-obj-$(CONFIG_DVB_LGDT3302) += lgdt3302.o
+obj-$(CONFIG_DVB_LGDT330X) += lgdt330x.o
drivers/media/dvb/frontends/Kconfig +2 -2
diff -u linux-2.6.13/drivers/media/dvb/frontends/Kconfig linux/drivers/media/dvb/frontends/Kconfig
@@ -187,8 +187,8 @@
 	  An ATSC 8VSB/16VSB and QAM64/256 tuner module. Say Y when you want to
 	  support this frontend.
 
-config DVB_LGDT3302
-	tristate "LGDT3302 based (DViCO FusionHDTV3 Gold)"
+config DVB_LGDT330X
+	tristate "LGDT3302 or LGDT3303 based (DViCO FusionHDTV Gold)"
 	depends on DVB_CORE
 	help
 	  An ATSC 8VSB and QAM64/256 tuner module. Say Y when you want
#1 lore raw

PSX Gamepad Support

Hello,

I have an adapter usb to psx i have tried it with 2.6.9 and it works perfectly with the kernel driver. with 2.6.12 i cant get it to work and with 2.6.13-rc3 i havent seen any option to enable it. could anybody help me?

Greets and thanks

c. litters

#2 lore raw

[DRIVER] Where is the PSX Gamepad Driver in 2.6.13-rc3?

In reply to Michael Krufky

Hello,

I have an adapter usb to psx i have tried it with 2.6.9 and it works perfectly with the kernel driver.
with 2.6.12 i cant get it to work and with 2.6.13-rc3 i havent seen any option to enable it.
could anybody help me?

Greets and thanks

c. litters

#3 lore raw

Re: [DRIVER] Where is the PSX Gamepad Driver in 2.6.13-rc3?

Quoted 8 lines · Christoph Litters

Hello,

I have an adapter usb to psx i have tried it with 2.6.9 and it works perfectly with the kernel driver.
with 2.6.12 i cant get it to work and with 2.6.13-rc3 i havent seen any option to enable it.
could anybody help me?

Device Drivers ---> Input device support ---> Joysticks ---> Multisystem, NES, SNES, N64, PSX joysticks and gamepads

Needs parport support.

Signature · 1 line
Dmitry
#4 lore raw

Re: [DRIVER] Where is the PSX Gamepad Driver in 2.6.13-rc3?

Quoted 12 lines · Dmitry Torokhov wrote/
Quoted 8 lines · Christoph Litters

Hello,

I have an adapter usb to psx i have tried it with 2.6.9 and it works perfectly with the kernel driver.
with 2.6.12 i cant get it to work and with 2.6.13-rc3 i havent seen any option to enable it.
could anybody help me?

Quoted 4 lines

Device Drivers ---> Input device support ---> Joysticks ---> Multisystem, NES, SNES, N64, PSX joysticks and gamepads

Needs parport support.

Are you sure? Isn't this only for parallel to psx adapters? Christoph says he has a "usb to psx" adapter.

Eric

#5 lore raw

Re: [DRIVER] Where is the PSX Gamepad Driver in 2.6.13-rc3?

Quoted 13 lines · Eric Piel
Quoted 12 lines · Dmitry Torokhov wrote/
Quoted 8 lines · Christoph Litters

Hello,

I have an adapter usb to psx i have tried it with 2.6.9 and it works perfectly with the kernel driver.
with 2.6.12 i cant get it to work and with 2.6.13-rc3 i havent seen any option to enable it.
could anybody help me?

Quoted 9 lines
Quoted 5 lines

Device Drivers ---> Input device support ---> Joysticks ---> Multisystem, NES, SNES, N64, PSX joysticks and gamepads

Needs parport support.

Are you sure? Isn't this only for parallel to psx adapters? Christoph says he has a "usb to psx" adapter.

Oh, yes, sorry. In that case wouldn't HID driver handle it?

Signature · 1 line
Dmitry
#6 lore raw

Re: [DRIVER] Where is the PSX Gamepad Driver in 2.6.13-rc3?

Quoted 27 lines · Dmitry Torokhov
Quoted 24 lines · Eric Piel
Quoted 21 lines · Dmitry Torokhov wrote/
Quoted 10 lines · Christoph Litters

Hello,

I have an adapter usb to psx i have tried it with 2.6.9 and it works perfectly with the kernel driver.
with 2.6.12 i cant get it to work and with 2.6.13-rc3 i havent seen any option to enable it.
could anybody help me?

Device Drivers ---> Input device support ---> Joysticks ---> Multisystem, NES, SNES, N64, PSX joysticks and gamepads

Needs parport support.

Quoted 10 lines
Quoted 5 lines

Are you sure? Isn't this only for parallel to psx adapters? Christoph says he has a "usb to psx" adapter.

Oh, yes, sorry. In that case wouldn't HID driver handle it?

I have such a device myself (send me an email in private if you want to confirm it is the same model et al). The HID driver worked just fine. I also found that there was almost zero information about this on the net. I just use USB, USB HID, USB HID input support, Input support, and the Input joystick interface driver. Works just fine, check it with the joystick calibrator program of your choice. If your PSX -> USB converter doesn't support the joystick HID (which most seem to do) you may need a driver of some kind. Or better yet go buy one that does support it, you should be able to pick one up for less than $20 USD.

Matt