ALSA memory allocator rants
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi,
Here is a email I received as a result of talks I had at KS.
The general point is that they want the memory alloc function calls in alsa-kernel to not be calls to wrappers, but instead be proper kernel 2.6 function calls. The other general point is that some of the code we use should be generalised so that other non-audio drivers can reuse it.
Comments please,
James
Quoted 45 lines · Christoph Hellwig
At KS I promised you to send you my rants about ALSA memory allocations, so here we go finally.
First stance from me is that a subsystem needing it's own memory allocation helpers is always a bug, either in the subsystem or in the generic allocators. In the ALSA case we have both..
sound/core/memalloc.c:-
snd_dma_hack_alloc_coherentshouldn't exist, instead the archdma_alloc_coherentshould do hacks similar to it. The kmalloc_dev/kmalloc_mask as proposed at KS should fix this
-snd_malloc_pagesis bogus. the only additional thing it does over__get_free_pagesis to set the page reserved which is the wrong thing to do (we're getting rid of PageReserved soon)
-snd_malloc_dev_pagesshould be justdma_alloc_coherent, the__GFP_FLAGclearing should be in those, and playing PageReserved tricks with dma coherent memory is totally wrong in any case
- dito forsnd_malloc_sbus_pages, mid-term I'd love to see one of the sparc hackers to switch sparc to support sbus withdma_alloc_coherent
- what's the point ofsnd_dma_alloc_pages()? It supports very different kinds of memory allocations, and overloads the device field in non-trivial ways. The code would get a lot cleaner by letting everyone call the allocator they actually need instead of adding such broken 'abstractions'. Same thing can be said about structsnd_dma_buffer.
-snd_dma_alloc_pages_fallbackshould go to generic dma code, it's not sound specific
- preallocations should go into generic code or go away, it has no business in sound code
- similar dma coherent stats should go into generic dma code
sound/core/memory.c- all this should happen at the slab level, not in some subsystem
sound/core/sgbuf.c- something like this should go into generic code, lots of video drivers need something like this. They use streaming dma mappings, though while alsa wants consistant ones. In general doing this on consistant ones can't be done in architecture-independent code, what alsa does now does lots of assumptions about how
dma_alloc_coherentis implemented, and it can't work on arm for example.
Quoted 5 lines
sound/core/pcm_memory.c- same preallocation comment as above.
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
At Sun, 31 Jul 2005 16:46:44 +0100,
Quoted 10 lines · James Courtier-Dutton
Hi,
Here is a email I received as a result of talks I had at KS. The general point is that they want the memory alloc function calls in alsa-kernel to not be calls to wrappers, but instead be proper kernel 2.6 function calls.
The other general point is that some of the code we use should be generalised so that other non-audio drivers can reuse it.
Quoted 18 lines
Comments please,
James
Quoted 12 lines · Christoph Hellwig
At KS I promised you to send you my rants about ALSA memory allocations, so here we go finally.
First stance from me is that a subsystem needing it's own memory allocation helpers is always a bug, either in the subsystem or in the generic allocators. In the ALSA case we have both..
sound/core/memalloc.c:-
snd_dma_hack_alloc_coherentshouldn't exist, instead the archdma_alloc_coherentshould do hacks similar to it. The kmalloc_dev/kmalloc_mask as proposed at KS should fix this
Yep. As it name stands, it's a pure hack :)
Quoted 3 lines
Quoted 3 lines
-
snd_malloc_pagesis bogus. the only additional thing it does over__get_free_pagesis to set the page reserved which is the wrong thing to do (we're getting rid of PageReserved soon)
The page reservataion was necessary for older kernels, but yes, we can surely clean up them for the recent 2.6.
Quoted 3 lines
Quoted 3 lines
-
snd_malloc_dev_pagesshould be justdma_alloc_coherent, the__GFP_FLAGclearing should be in those, and playing PageReserved tricks with dma coherent memory is totally wrong in any case
Ditto.
Quoted 2 lines
Quoted 2 lines
- dito for
snd_malloc_sbus_pages, mid-term I'd love to see one of the sparc hackers to switch sparc to support sbus withdma_alloc_coherent
Agreed.
Quoted 6 lines
Quoted 6 lines
- what's the point of
snd_dma_alloc_pages()? It supports very different kinds of memory allocations, and overloads the device field in non-trivial ways. The code would get a lot cleaner by letting everyone call the allocator they actually need instead of adding such broken 'abstractions'. Same thing can be said about structsnd_dma_buffer.
Since the buffer may be allocated dynacmially via snd_pcm_lib_malloc_pages() at each open, the PCM common layer needs to remember the type of buffer allocation. Having a common allocator is nice for this purpose. The allocator is called in different places, i.e. the pre-allocation and the dynamic allocation.
Quoted 5 lines
Quoted 5 lines
-
snd_dma_alloc_pages_fallbackshould go to generic dma code, it's not sound specific
- preallocations should go into generic code or go away, it has no business in sound code
- similar dma coherent stats should go into generic dma code
Yes, we need just a good API... :)
Quoted 3 lines
Quoted 3 lines
sound/core/memory.c- all this should happen at the slab level, not in some subsystem
Unfortunately, it can't be easily handled in the slab level (as it is). The point of the debug code in this file is to detect the memory leak in the subsystem (or module) level.
Quoted 8 lines
Quoted 8 lines
sound/core/sgbuf.c- something like this should go into generic code, lots of video drivers need something like this. They use streaming dma mappings, though while alsa wants consistant ones. In general doing this on consistant ones can't be done in architecture-independent code, what alsa does now does lots of assumptions about how
dma_alloc_coherentis implemented, and it can't work on arm for example.
Yeah, the generic code would be much better for this.
Quoted 3 lines
Quoted 3 lines
sound/core/pcm_memory.c- same preallocation comment as above.
Agreed.
Takashi
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click