Skip to contentSkip to conversation

NFS - Missing unlock_kernel() in lookup path

PATCH New Steve Dickson 1 participant 1 message Aug 1, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NFS - Missing unlock_kernel() in lookup path

Hey Trond,

I was backport some patches and noticed that nfs_atomic_lookup() seems to be missing an unlock_kernel()... I would think that nfs_atomic_lookup() should unlock_kernel() when nfs_revalidate_inode() fails... true?

steved.

Added missing unlock_kernel() to NFS lookup patch.

-----------------------------------------------

fs/nfs/dir.c renamed from fs/nfs/dir.c.orig +1 -0
@@ -835,6 +835,7 @@ static struct dentry *nfs_atomic_lookup(
 	error = nfs_revalidate_inode(NFS_SERVER(dir), dir);
 	if (error < 0) {
 		res = ERR_PTR(error);
+		unlock_kernel();
 		goto out;
 	}