argh... ;/
Subsystems (2)
I accidentaly posted the patches as MIME attachments... its 5:03 am here already. Sorry guys. I can resubmit if you want. I just dont want do that now and not trash your mailboxes
Mateusz
Quoted 4 lines · Mateusz Berezecki
I accidentaly posted the patches as MIME attachments... its 5:03 am here already. Sorry guys.
I can resubmit if you want. I just dont want do that now and not trash your mailboxes
Does anybody still care if patches are posted as attachments, particularly for review as opposed to submission?
I will make the standard comment about C99 // comments, but add that I use them myself to mean "this comment will definitely be gone by the time it gets officially submitted", in other words, work in progress.
Heroic work! And nicely lindented at least. Some long lines, but in the same kinds of places I write them myself.
Only commenting on the form, not substance. Best of luck. I have one of these things here so when you declare it ready I will try it.
Regards,
Daniel
Quoted 5 lines · Daniel Phillips
Quoted 1 line · Mateusz Berezecki
I accidentaly posted the patches as MIME attachments... its 5:03 am here
Does anybody still care if patches are posted as attachments, particularly for review as opposed to submission?
Yes. Opening attachments makes them harder to review.
Signature · 2 lines
John W. Linville [email protected]
Quoted 11 lines · John W. Linville
Quoted 6 lines · Daniel Phillips
Quoted 1 line · Mateusz Berezecki
I accidentaly posted the patches as MIME attachments... its 5:03 am here
Does anybody still care if patches are posted as attachments, particularly for review as opposed to submission?
Yes. Opening attachments makes them harder to review.
Strongly agreed.
Jeff
Quoted 8 lines · John W. Linville
Quoted 5 lines · Daniel Phillips
Quoted 1 line · Mateusz Berezecki
I accidentaly posted the patches as MIME attachments... its 5:03 am here
Does anybody still care if patches are posted as attachments, particularly for review as opposed to submission?
Yes. Opening attachments makes them harder to review.
Indeed. Replying to such mails ends up looking like..
Quoted 1 line
---end quoted text---
Which means you need to futz around saving it, reading it back in, deleting it etc.. Saving reviewers keystrokes == good thing.
Dave
Quoted 6 lines · Dave Jones
Quoted 5 lines · John W. Linville
Quoted 4 lines · Daniel Phillips
Quoted 2 lines · Mateusz Berezecki
I accidentaly posted the patches as MIME attachments... its 5:03 am here
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Does anybody still care if patches are posted as attachments, particularly for review as opposed to submission?
Yes. Opening attachments makes them harder to review.
Indeed. Replying to such mails ends up looking like..
Hi, sorry, about the misfired "test" mail... the _real_ issue for me was that Kmail was turning tabs into spaces for the longest time, so forcing me either to switch mailers (and you know how appealing that is) or send patches as attachments. It's finally fixed, so I'll happily join in with dumping on the poor misguided folks who insist on posting their patches as attachments.
Regards,
Daniel "the flexible" Phillips
Quoted 1 line · John W. Linville
Yes. Opening attachments makes them harder to review.
Lots of people can't inline patches because they are inflicted with crappy MUAs --- I would much prefer patches as attachments in those cases versus mangled patches.
Also, I would arguue any sane MUA would make dealing with reading/openning patches for sensible mime types trivial.
Quoted 10 lines · Chris Wedgwood
Quoted 1 line · John W. Linville
Yes. Opening attachments makes them harder to review.
Lots of people can't inline patches because they are inflicted with crappy MUAs --- I would much prefer patches as attachments in those cases versus mangled patches.
Also, I would arguue any sane MUA would make dealing with reading/openning patches for sensible mime types trivial.
That may break quilt import and probably other tools; having to teach quilt about MIME would be a horribly pointless exercise.
Ralf
Quoted 7 lines · Chris Wedgwood
Quoted 1 line · John W. Linville
Yes. Opening attachments makes them harder to review.
Lots of people can't inline patches because they are inflicted with crappy MUAs --- I would much prefer patches as attachments in those cases versus mangled patches.
Don't use crappy MUAs?
Quoted 2 lines
Also, I would arguue any sane MUA would make dealing with reading/openning patches for sensible mime types trivial.
Any sane MUA wouldn't mangle the patches...
John
Signature · 2 lines
John W. Linville [email protected]
Quoted 1 line · John W. Linville
Don't use crappy MUAs?
Well, plenty of people do. It's almost the norm so crappy probably isn't very fair.
It does seem that most if the GUI-base MUAs though by default have problematic settings (Mozilla, Thunderbird, Evolution, Outlook all have problems at tims).
People also like to cut & paste patches from xterms or simlar into MUAs which usually doesn't work very well either.