mm: Export follow_pte() for KVM so that KVM can stop using follow_pfn()
Subsystems (3)
Sean Christopherson
reviewerPATCH 1/1 mm: Export follow_pte() for KVM so that KVM can stop using follow_pfn()
Export follow_pte() to fix build breakage when KVM is built as a module. An in-flight KVM fix switches from follow_pfn() to follow_pte() in order to grab the page protections along with the PFN.
---
Paolo, maybe you can squash this with the appropriate acks?
mm/memory.c | 1 + 1 file changed, 1 insertion(+)
mm/memory.c +1 -0
@@ -4775,6 +4775,7 @@ int follow_pte(struct mm_struct *mm, unsigned long address, out:return -EINVAL ; } +EXPORT_SYMBOL_GPL (follow_pte);/** * follow_pfn - look up PFN at a user virtual address
Signature · 1 line
2.30.0.365.g02bc693789-goog
Paolo Bonzini
maintainerQuoted 11 lines · Sean Christopherson
Export
follow_pte()to fix build breakage when KVM is built as a module. An in-flight KVM fix switches fromfollow_pfn()tofollow_pte()in order to grab the page protections along with the PFN.Fixes bd2fae8da794 ("KVM: do not assume PTE is writable after follow_pfn")Cc David Stevens <[email protected]>Cc Jann Horn <[email protected]>Cc Jason Gunthorpe <[email protected]>Cc Paolo Bonzini <[email protected]>Signed-off-by Sean Christopherson <[email protected]>
Quoted 3 lines
---
Paolo, maybe you can squash this with the appropriate acks?
Indeed, you beat me by a minute. This change is why I hadn't sent out the patch yet.
Andrew or Jason, ok to squash this?
Paolo
Quoted 16 lines
mm/memory.c | 1 + 1 file changed, 1 insertion(+)mm/memory.c +1
-0@@ -4775,6 +4775,7 @@ int follow_pte(struct mm_struct *mm, unsigned long address, out:return -EINVAL ; } +EXPORT_SYMBOL_GPL (follow_pte);/** * follow_pfn - look up PFN at a user virtual address
Quoted 13 lines · Paolo Bonzini
Quoted 12 lines · Sean Christopherson
Export
follow_pte()to fix build breakage when KVM is built as a module. An in-flight KVM fix switches fromfollow_pfn()tofollow_pte()in order to grab the page protections along with the PFN.Fixes bd2fae8da794 ("KVM: do not assume PTE is writable after follow_pfn")Cc David Stevens <[email protected]>Cc Jann Horn <[email protected]>Cc Jason Gunthorpe <[email protected]>Cc Paolo Bonzini <[email protected]>Signed-off-by Sean Christopherson <[email protected]>
Quoted 6 lines
Quoted 1 line
Paolo, maybe you can squash this with the appropriate acks?
Indeed, you beat me by a minute. This change is why I hadn't sent out the patch yet.
Andrew or Jason, ok to squash this?
I think usual process would be to put this in the patch/series/pr that needs it.
Given how badly follow_pfn has been misused, I would greatly prefer to see you add a kdoc along with exporting it - making it clear about the rules.
And it looks like we should remove the range argument for modular use
And document the locking requirements, it does a lockless read of the page table:
pgd = pgd_offset(mm, address); if (pgd_none(*pgd) || unlikely(pgd_bad(*pgd))) goto out; p4d = p4d_offset(pgd, address);
It doesn't do the trickery that fast GUP does, so it must require the mmap sem in read mode at least.
Not sure I understand how fsdax is able to call it only under the i_mmap_lock_read lock? What prevents a page table level from being freed concurrently?
And it is missing READ_ONCE's for the lockless page table walk.. :(
Jason