Skip to contentSkip to conversation

net/ice: fix QinQ switch rule input set mask

PATCH Applied Yuying Zhang 2 participants 2 messages Feb 4, 2021 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/ice: fix QinQ switch rule input set mask

QinQ switch rule doesn't support ethertype field match. QinQ ethertype pattern should not be created. Change the input set mask to fix the issue.

Fixes bb3386f348dd ("net/ice: enable QinQ filter for switch")
---
 drivers/net/ice/ice_switch_filter.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ice/ice_switch_filter.c +2 -1
index 5ca0985e21..6525e6c115 100644
@@ -38,7 +38,8 @@
 	ICE_INSET_DMAC | ICE_INSET_SMAC | ICE_INSET_ETHERTYPE | \
 	ICE_INSET_VLAN_INNER)
 #define ICE_SW_INSET_MAC_QINQ  ( \
-	ICE_SW_INSET_MAC_VLAN | ICE_INSET_VLAN_OUTER)
+	ICE_INSET_DMAC | ICE_INSET_SMAC | ICE_INSET_VLAN_INNER | \
+	ICE_INSET_VLAN_OUTER)
 #define ICE_SW_INSET_MAC_IPV4 ( \
 	ICE_INSET_DMAC | ICE_INSET_IPV4_DST | ICE_INSET_IPV4_SRC | \
 	ICE_INSET_IPV4_PROTO | ICE_INSET_IPV4_TTL | ICE_INSET_IPV4_TOS)
Signature · 1 line
2.25.1
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Zhang, Yuying <[email protected]>
Sent: Thursday, February 4, 2021 2:08 PM
To: [email protected]; Zhang, Qi Z <[email protected]>; Wang, Haiyue <[email protected]>
Cc: Fu, Qi <[email protected]>; Zhang, Yuying <[email protected]>
Subject: [PATCH v1] net/ice: fix QinQ switch rule input set mask

Quoted 7 lines

QinQ switch rule doesn't support ethertype field match.
QinQ ethertype pattern should not be created. Change the input set mask to fix the issue.

Fixes bb3386f348dd ("net/ice: enable QinQ filter for switch")

Applied to dpdk-next-net-intel.

Thanks
Qi