Skip to contentSkip to conversation

raid5-cache: add crc32c Kconfig dependency

PATCH Applied Arnd Bergmann 2 participants 2 messages Nov 3, 2015 – Nov 6, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 raid5-cache: add crc32c Kconfig dependency

The recent change of the raid5-cache code to use crc32c instead of crc32 causes link errors when CONFIG_LIBCRC32C is disabled:

drivers/built-in.o: In function crc32c' core.c:(.text+0x1c6060): undefined reference to `crc32c'

This adds an explicit 'select' statement like all other users of this function do.

Fixes 5cb2fbd6ea0d ("raid5-cache: use crc32c checksum")
drivers/md/Kconfig +1 -0
index 3e01e6fb3424..7913fdcfc849 100644
@@ -123,6 +123,7 @@ config MD_RAID456
 	tristate "RAID-4/RAID-5/RAID-6 mode"
 	depends on BLK_DEV_MD
 	select RAID6_PQ
+	select LIBCRC32C
 	select ASYNC_MEMCPY
 	select ASYNC_XOR
 	select ASYNC_PQ
Applied
#1 lore raw
Quoted 17 lines · Arnd Bergmann

The recent change of the raid5-cache code to use crc32c instead of crc32 causes link errors when CONFIG_LIBCRC32C is disabled:

drivers/built-in.o: In function crc32c' core.c:(.text+0x1c6060): undefined reference to `crc32c'

This adds an explicit 'select' statement like all other users of this function do.

Fixes 5cb2fbd6ea0d ("raid5-cache: use crc32c checksum")
drivers/md/Kconfig +0 -0
index 3e01e6fb3424..7913fdcfc849 100644

drivers/md/Kconfig config MD_RAID456 · line 129

Quoted 7 lines
drivers/md/Kconfig +1 -0
@@ -123,6 +123,7 @@ config MD_RAID456
 	tristate "RAID-4/RAID-5/RAID-6 mode"
 	depends on BLK_DEV_MD
 	select RAID6_PQ
+	select LIBCRC32C
 	select ASYNC_MEMCPY
 	select ASYNC_XOR
 	select ASYNC_PQ

Applied, thanks,

NeilBrown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151106/87dc5111/attachment.sig>