Skip to contentSkip to conversation

fix make dependencies for at91rm9200 and ks8695 cpus

PATCH New Steven Scholz 2 participants 4 messages Aug 23, 2005 – Aug 24, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix make dependencies for at91rm9200 and ks8695 cpus

Hi there,

please apply the attached patch.

Without this patch lowlevel_init.s is _not_ rebuild when board config file (or other important include files) is changed!

Signature · 5 lines
Steven
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fix_dep.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050823/aa886b08/attachment.txt 
#1 lore raw

PATCH 1/1 fix make dependencies for at91rm9200 and ks8695 cpus

Review

Quoted 3 lines · In message <[email protected]> you wrote:
(quoted diff) +2 -0
+* Fix make dependencies for at91rm9200 and ks8695 cpus
+  Patch by Steven Scholz, 23 Aug 2005

Added, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Humans do claim a great deal for that particular emotion (love).
	-- Spock, "The Lights of Zetar", stardate 5725.6
#2 lore raw

PATCH 1/1 fix make dependencies for at91rm9200 and ks8695 cpus

Quoted 7 lines · Wolfgang Denk

Review

Quoted 2 lines · In message <[email protected]> you wrote:
(quoted diff) +2 -0
+* Fix make dependencies for at91rm9200 and ks8695 cpus
+  Patch by Steven Scholz, 23 Aug 2005

Added, thanks.

Thanks.

Sorry I did not create it git format-patch. I am still not sure how to use it. Maybe you could add a few lines in your Wiki.

BTW: Was it ok to change the CHANGELOG? You asked for it in your mail "U-Boot Developer's Information":

"Make sure to update the CHANGELOG file appropriately."

But I think unless you apply patches immediatly patching CHANGLOG will always fail. So maybe it's better to have a CHANGELOG entry in the email body instead of the attached patch ...

--
Steven

#3 lore raw

PATCH 1/1 fix make dependencies for at91rm9200 and ks8695 cpus

Quoted 3 lines · In message <[email protected]> you wrote:

Sorry I did not create it git format-patch. I am still not sure how to use it. Maybe you could add a few lines in your Wiki.

This was OK.

Quoted 1 line

BTW: Was it ok to change the CHANGELOG? You asked for it in your mail

Yes.

Quoted 3 lines

But I think unless you apply patches immediatly patching CHANGLOG will always fail. So maybe it's better to have a CHANGELOG entry in the email body instead of the attached patch ...

I'm still experimenting with both ways. Yes, having the CHANGELOG modified by the patch will usually cause merge conflicts, but then I have all information in one file and don't need to jump between the mailer window and my vi session.

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Half of the people in the world are below average.