Skip to contentSkip to conversation

Netdevice reference counting issues in net/core/dv.c

DISCUSSION Ben Greear 1 participant 1 message Aug 28, 2005

Subsystems (2)
lore
Share & tools
lore

Ben Greear

author
#0 lore raw

dv.c has several issues.

First, it uses the check_args method to find the device. It acquires a hold on the device and then drops it in the same method. Upon return from this check_args method, code then continues to use the reference to the device. This could lead to access-after-free errors.

Also, check_args has an arbitrary device-index check to make sure it is less that 1000. This is bogus since we can have many more devices than that...

If there is a maintainer that wants to fix this, please be my guest. Otherwise, I'll make a stab at fixing it as part of my ref-count debugging work.

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com