Kconfig: saa7134-dvb must select tda1004x

I wish I had seen this before 2.6.13 was released... I guess this only goes to show that there haven't been any testers using saa7134-hybrid dvb/v4l boards that depend on the tda1004x module, during the 2.6.13-rc series :-(

Please apply this to 2.6.14, and also to 2.6.13.1 -stable. Without this patch, users will have to EXPLICITLY select tda1004x in Kconfig. This SHOULD be done automatically when saa7134-dvb is selected. This patch corrects this problem.

saa7134-dvb must select tda1004x

 linux/drivers/media/video/Kconfig |    1 +
 1 files changed, 1 insertion(+)

diff -u linux-2.6.13/drivers/media/video/Kconfig linux/drivers/media/video/Kconfig
@@ -254,6 +254,7 @@
 	select VIDEO_BUF_DVB
 	select DVB_MT352
 	select DVB_CX22702
+	select DVB_TDA1004X
 	---help---
 	  This adds support for DVB cards based on the
 	  Philips saa7134 chip.

What about the patch below fixing the following similar problems in drivers/media/dvb/ttpci/budget-ci.c ?

cu
Adrian

<-- snip -->

Add missing select's to DVB_BUDGET_AV fixing the following compile error:

<-- snip -->

...
LD .tmp_vmlinux1
drivers/built-in.o: In function `frontend_init':
budget-av.c:(.text+0xb9448): undefined reference to tda10046_attach' budget-av.c:(.text+0xb9518): undefined reference to tda10021_attach' drivers/built-in.o: In function `philips_tu1216_request_firmware':
budget-av.c:(.text+0xb937b): undefined reference to `request_firmware'
make: *** [.tmp_vmlinux1] Error 1

<-- snip -->

@@ -99,12 +99,15 @@
 config DVB_BUDGET_AV
 	tristate "Budget cards with analog video inputs"
 	depends on DVB_CORE && PCI
 	select VIDEO_DEV
 	select VIDEO_SAA7146_VV
 	select DVB_STV0299
+	select DVB_TDA1004X
+	select DVB_TDA10021
+	select FW_LOADER
 	help
 	  Support for simple SAA7146 based DVB cards
 	  (so called Budget- or Nova-PCI cards) without onboard
 	  MPEG2 decoder, but with one or more analog video inputs.
 
 	  Say Y if you own such a card and want to use it.

I also added this to linuxtv.org CVS. But I'm not sure it is critical enough to put it in stable.

Thanks,
Johannes

If I were a -stable maintainer, I'd include both patches after they were included in Linus' tree and shipped with one -rc or -mm kernel.

But that's not a strong opinion, it's also OK for me if the patches don't get included in 2.6.13.x .

cu
Adrian

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Adrian-

About saa7134-dvb patch, it is already in -mm and the 2.6.13.y stable patch queue, but not yet in -git. Nobody will complain about it when it comes time for 2.6.13.1 review, as it was only left out of 2.6.13 by accident. I sent that in, as it is technically part of v4l tree (even though it handles DVB code, saa7134-dvb.c is a hybrid v4l file). This is (probably) the reason why JS didn't send an ACK on my patch, but I bet Mauro will ACK it when Chris starts the 2.6.13.1-stable review on LKML.

Good looking on the budget_av patch :-) ... I was just about to respond to your email before I saw that Johannes already did. IMHO, I agree that your budget_av patch couldn't hurt to go to stable as well, but since JS says it isn't critical, I think you might need to lobby to him to change his mind. Personally, I think that both patches should go to 2.6.13.y -stable, as it IS a behavior correction for Kconfig kernel compilation, and without these patches, some users may be left confused with supported hardware that won't work (without some googling). I think it is best for user-friendliness to apply these ASAP.

If you choose to send it to stable, feel free to add:

...although, since I am not the official maintainer (Johannes is) I don't think my ACK matters by much :-(

-MiKE Krufky