Skip to contentSkip to conversation

Runtime linkage fix for serial_cs

TRIVAL Takeharu KATO 2 participants 3 messages Sep 3, 2005

lore
Share & tools
lore
#0 lore raw

Hi

I found current serial_cs driver can not be loaded into the kernel.
The reason of this issue is serial_cs driver uses serial8250_unregister_port function which is not exported for modules.
I fixed the issue, please apply this patch.

Signed-off-by [email protected]
drivers/serial/serial_cs.c 2005-08-24 00:16:09.297664592 +0900 renamed from drivers/serial/serial_cs.c 2005-06-27 15:06:42.000000000 +0900 +1 -1
diff -NBbur linux.orig/drivers/serial/serial_cs.c linux/drivers/serial/serial_cs.c
@@ -139,7 +139,7 @@
         */
        if (info->link.state & DEV_CONFIG) {
                for (i = 0; i < info->ndev; i++)
-                       serial8250_unregister_port(info->line[i]);
+                       unregister_serial(info->line[i]);
 
                info->link.dev = NULL;
 
#1 lore raw
Quoted 3 lines · Takeharu KATO

I found current serial_cs driver can not be loaded into the kernel. The reason of this issue is serial_cs driver uses serial8250_unregister_port function which is not exported for modules.

Your kernel sources are buggy. This function is exported.

Quoted 1 line

I fixed the issue, please apply this patch.

This is not a fix - unregister_serial() must not be used with ports registered with serial8250_register_port(), and in fact unregister_serial() no longer exists.

You need to find out why your tree doesn't export serial8250_unregister_port(). Mis-merged patch maybe?

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
#2 lore raw

Hi

Quoted 3 lines

You need to find out why your tree doesn't export serial8250_unregister_port(). Mis-merged patch maybe?

Thank you for your response.
I'll check our kernel again.