ipset compilation fails on kernel 2.6.13

Hello,

Using sources found on http://ipset.netfilter.org/install.html, and also the latest iptables & pom-ng, I cannot get ipset to compile without errors :

CC [M] net/ipv4/netfilter/ip_set.o
net/ipv4/netfilter/ip_set.c:35: attention : type defaults to int' in declaration of DECLARE_RWLOCK' net/ipv4/netfilter/ip_set.c:35: attention : noms de paramètres (sans type) dans la déclaration de fonction net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_find_in_hash »:
net/ipv4/netfilter/ip_set.c:86: attention : implicit declaration of function MUST_BE_READ_LOCKED' net/ipv4/netfilter/ip_set.c:86: error: ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c:86: error: (Each undeclared identifier is reported only once net/ipv4/netfilter/ip_set.c:86: error: for each function it appears in.) net/ipv4/netfilter/ip_set.c: Dans la fonction « __set_hash_del »:
net/ipv4/netfilter/ip_set.c:103: attention : implicit declaration of function MUST_BE_WRITE_LOCKED' net/ipv4/netfilter/ip_set.c:103: error: ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_hash_del »:
net/ipv4/netfilter/ip_set.c:120: attention : implicit declaration of function WRITE_LOCK' net/ipv4/netfilter/ip_set.c:120: error: ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c:129: attention : implicit declaration of function `WRITE_UNLOCK' net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_hash_add »:
net/ipv4/netfilter/ip_set.c:145: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_testip_kernel »:
net/ipv4/netfilter/ip_set.c:210: attention : implicit declaration of function READ_LOCK' net/ipv4/netfilter/ip_set.c:210: error: ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c:221: attention : implicit declaration of function `READ_UNLOCK' net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_addip_kernel »:
net/ipv4/netfilter/ip_set.c:237: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_delip_kernel »:
net/ipv4/netfilter/ip_set.c:266: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_register_set_type »:
net/ipv4/netfilter/ip_set.c:310: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_unregister_set_type »:
net/ipv4/netfilter/ip_set.c:332: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_bindip »:
net/ipv4/netfilter/ip_set.c:554: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_unbindip »:
net/ipv4/netfilter/ip_set.c:632: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « find_set_type_rlock »:
net/ipv4/netfilter/ip_set.c:744: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_create »:
net/ipv4/netfilter/ip_set.c:835: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_destroy_set »:
net/ipv4/netfilter/ip_set.c:897: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_rename »:
net/ipv4/netfilter/ip_set.c:973: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_swap »:
net/ipv4/netfilter/ip_set.c:1007: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Dans la fonction « ip_set_restore »:
net/ipv4/netfilter/ip_set.c:1335: error: `ip_set_lock' undeclared (first use in this function) net/ipv4/netfilter/ip_set.c: Hors de toute fonction :
net/ipv4/netfilter/ip_set.c:35: attention : DECLARE_RWLOCK' declared static' but never defined make[3]: *** [net/ipv4/netfilter/ip_set.o] Erreur 1
make[2]: *** [net/ipv4/netfilter] Erreur 2
make[1]: *** [net/ipv4] Erreur 2

Should I use another kernel ?

It would appear that ipset was not cleaned up to remove use of the macros that were in include/linux/netfilter_ipv4/lockhelp.h, which was removed in the 2.6.13 release. Check out an old copy of lockhelp.h for help in converting the failing macros.

Toby DiPasquale
0x636f6465736c696e67657240676d61696c2e636f6d

Thanx for your response,
adding an "include" for that file resolved the problem.