cciss: bug fix in cciss_remove_one
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 21 lines · Linux Kernel Mailing List
tree
30a07d018d74fbd99d323d6d6a6e08cac3a1b767
parent33079b21978f478865068ee6a3c5807b6c6ecdbe
author Mike Miller <[email protected]> Tue, 13 Sep 2005 15:25:23 -0700 committer Linus Torvalds <[email protected]> Tue, 13 Sep 2005 22:22:30 -0700[PATCH] cciss: bug fix in
cciss_remove_oneThis patch fixes a bug in
cciss_remove_one. A set of braces was missing for the if statement causing an Oops on driver unload.Signed-off-by Mike Miller <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Linus Torvalds <[email protected]>drivers/block/cciss.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/block/cciss.c static void __devexit cciss_remove_one ( · line 3100
Quoted 8 lines
drivers/block/cciss.c +2
-2@@ -3095,9 +3095,10 @@ static void __devexit cciss_remove_one (/* remove it from the disk list */ for (j =0 ; j <NWD ; j++) {struct gendisk *disk = hba[i]->gendisk[j]; -if (disk->flags &GENHD_FL_UP ) -blk_cleanup_queue (disk->queue); +if (disk->flags &GENHD_FL_UP ) {del_gendisk (disk); +blk_cleanup_queue (disk->queue);
hrm. Would be nice to get cciss patches reviewed by Jens or me, or somebody...
Take a look at drivers/block/sx8.c:carm_free_disks() for the proper way to do this.
Jeff